Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/finsupp/to_dfinsupp): add equivalences between finsupp and dfinsupp #7311

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(data/finsupp/to_dfinsupp): add equivalences between finsupp and dfinsupp #7311

wants to merge 6 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Apr 21, 2021 •
edited by github-actions bot
Loading

A rework of #7217, that adds a more elementary equivalence.

Open in Gitpod

@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 21, 2021
@eric-wieser eric-wieser mentioned this pull request Apr 21, 2021
Open
1 task
@eric-wieser eric-wieser force-pushed the eric-wieser/finsupp.to_dfinsupp branch from 737adbc to fca7380 Compare April 21, 2021 16:21
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Apr 22, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@bryangingechen bryangingechen added the awaiting-author A reviewer has asked the author a question or requested changes label Apr 22, 2021
@eric-wieser eric-wieser force-pushed the eric-wieser/finsupp.to_dfinsupp branch from fca7380 to 2bdcd19 Compare April 22, 2021 12:17
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 22, 2021
kbuzzard
kbuzzard approved these changes Apr 24, 2021
View reviewed changes
Copy link
Member

@kbuzzard kbuzzard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I look forward to using this stuff in the graded ring API. Thanks!

src/data/finsupp/to_dfinsupp.lean Outdated Show resolved Hide resolved
src/data/finsupp/to_dfinsupp.lean Outdated Show resolved Hide resolved
src/data/finsupp/to_dfinsupp.lean Outdated Show resolved Hide resolved
src/data/finsupp/to_dfinsupp.lean Outdated Show resolved Hide resolved
@eric-wieser @kbuzzard
Apply suggestions from code review
16d2a3a 
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@eric-wieser
Copy link
Member Author

eric-wieser commented Apr 28, 2021 •
edited
Loading

Whoops, I somehow missed your review comments. Addressed, thanks for catching the add_zero_class mistake.

@semorrison
Copy link
Collaborator

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 29, 2021
bors bot pushed a commit that referenced this pull request Apr 29, 2021
@eric-wieser
feat(data/finsupp/to_dfinsupp): add equivalences between finsupp and …
91604cb 
…dfinsupp (#7311)

A rework of #7217, that adds a more elementary equivalence.
@bors
Copy link

bors bot commented Apr 29, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/finsupp/to_dfinsupp): add equivalences between finsupp and dfinsupp [Merged by Bors] - feat(data/finsupp/to_dfinsupp): add equivalences between finsupp and dfinsupp Apr 29, 2021
@bors bors bot closed this Apr 29, 2021
@bors bors bot deleted the eric-wieser/finsupp.to_dfinsupp branch April 29, 2021 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ocfnash ocfnash ocfnash left review comments

@kbuzzard kbuzzard kbuzzard approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
Graded modules, rings, and algebras
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@eric-wieser @semorrison @ocfnash @kbuzzard @bryangingechen