Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory/perm/{cycles, cycle_type}): permutations are conjugate iff they have the same cycle type #7335

Closed
wants to merge 72 commits into from

Conversation

awainverse
Copy link
Collaborator

Slightly strengthens the induction principle equiv.perm.cycle_induction_on
Proves that two permutations are conjugate iff they have the same cycle type: equiv.perm.is_conj_iff_cycle_type_eq


Open in Gitpod

@awainverse awainverse added the awaiting-review The author would like community review of the PR label Apr 23, 2021
@awainverse awainverse requested a review from tb65536 April 23, 2021 05:10
Copy link
Collaborator

@semorrison semorrison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I haven't touched this part of the library, so I'm hesitant to hit merge.

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 30, 2021
bors bot pushed a commit that referenced this pull request Apr 30, 2021
…ate iff they have the same cycle type (#7335)

Slightly strengthens the induction principle `equiv.perm.cycle_induction_on`
Proves that two permutations are conjugate iff they have the same cycle type: `equiv.perm.is_conj_iff_cycle_type_eq`



Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Co-authored-by: Thomas Browning <tb65536@uw.edu>
@bors
Copy link

bors bot commented Apr 30, 2021

Build failed (retrying...):

@fpvandoorn
Copy link
Member

I believe the new simp lemmas conflict with something in this failure

bors r-

@bors
Copy link

bors bot commented Apr 30, 2021

Canceled.

@awainverse
Copy link
Collaborator Author

Hopefully that fixes everything...

@awainverse
Copy link
Collaborator Author

The problem seems fixed, shall we try again?

@fpvandoorn
Copy link
Member

bors merge

@bryangingechen
Copy link
Collaborator

bors crashed
bors r+

bors bot pushed a commit that referenced this pull request May 2, 2021
…ate iff they have the same cycle type (#7335)

Slightly strengthens the induction principle `equiv.perm.cycle_induction_on`
Proves that two permutations are conjugate iff they have the same cycle type: `equiv.perm.is_conj_iff_cycle_type_eq`



Co-authored-by: Aaron Anderson <65780815+awainverse@users.noreply.github.com>
Co-authored-by: Thomas Browning <tb65536@uw.edu>
@bors
Copy link

bors bot commented May 2, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/perm/{cycles, cycle_type}): permutations are conjugate iff they have the same cycle type [Merged by Bors] - feat(group_theory/perm/{cycles, cycle_type}): permutations are conjugate iff they have the same cycle type May 2, 2021
@bors bors bot closed this May 2, 2021
@bors bors bot deleted the disjoint_conj branch May 2, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants