Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(order/closure): closure of unions and bUnions #7361

Closed
wants to merge 9 commits into from
Closed

[Merged by Bors] - feat(order/closure): closure of unions and bUnions #7361

wants to merge 9 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Apr 25, 2021 •
edited by jcommelin

prove closure_closure_union and similar

Open in Gitpod

@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Apr 25, 2021
eric-wieser
eric-wieser reviewed Apr 25, 2021
View reviewed changes
src/order/closure.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Apr 25, 2021
View reviewed changes
src/order/closure.lean Outdated Show resolved Hide resolved
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 25, 2021
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Apr 25, 2021
@YaelDillies
Copy link
Collaborator Author

I've added two new constructors mk2 and mk3. The names are lame and I'm not quite sure mk2 is that useful given it's strictly equivalent to mk3. The argument for it is that its arguments are closer to what one would write on paper when defining a closure operator.

eric-wieser
eric-wieser reviewed Apr 25, 2021
View reviewed changes
src/order/closure.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Apr 25, 2021
View reviewed changes
src/order/closure.lean Outdated Show resolved Hide resolved
@YaelDillies YaelDillies added WIP Work in progress and removed awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Apr 26, 2021
@YaelDillies
Copy link
Collaborator Author

Okay so I've been trying my two new constructors and they seem to work great for what I want. Specifically, mk2 and mk3 (if you think of better names...) do the same, but you can extract a sufficient property for being closed from mk3 (and not from mk2). This allows you for example to get convex.convex_hull_eq for free.

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels Apr 26, 2021
eric-wieser
eric-wieser reviewed Apr 26, 2021
View reviewed changes
src/order/closure.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Apr 26, 2021
View reviewed changes
src/order/closure.lean Outdated Show resolved Hide resolved
@YaelDillies @eric-wieser
generalized Type to Sort and set to α → Prop
695e217 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
eric-wieser reviewed Apr 28, 2021
View reviewed changes
src/order/closure.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed Apr 28, 2021
View reviewed changes
src/order/closure.lean Outdated Show resolved Hide resolved
b-mehta
b-mehta approved these changes Apr 28, 2021
View reviewed changes
Copy link
Collaborator

@b-mehta b-mehta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, modulo Eric's and my suggestions.

src/order/closure.lean Outdated Show resolved Hide resolved
@YaelDillies
Copy link
Collaborator Author

I've added a bunch of simp declarations. To this end, some lemmas have been turned around. I've hesitated a bit for le_closure_iff as I'm not sure it wouldn't be conflicting with closure_le_closed_iff_le.
I have also changed the statement of closure_bsupr_closure to be about a general predicate, not just a set. Not sure I got the syntax correct.

@YaelDillies YaelDillies mentioned this pull request May 3, 2021
Closed
1 task
jcommelin
jcommelin approved these changes May 6, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

bors bot pushed a commit that referenced this pull request May 6, 2021
@YaelDillies
feat(order/closure): closure of unions and bUnions (#7361)
8968564 
prove closure_closure_union and similar
@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 6, 2021
@bors
Copy link

bors bot commented May 6, 2021

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 6, 2021
@YaelDillies
feat(order/closure): closure of unions and bUnions (#7361)
6a182c4 
prove closure_closure_union and similar
@bors
Copy link

bors bot commented May 6, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 7, 2021
@YaelDillies
feat(order/closure): closure of unions and bUnions (#7361)
e56cd45 
prove closure_closure_union and similar
bors bot pushed a commit that referenced this pull request May 7, 2021
@YaelDillies
feat(order/closure): closure of unions and bUnions (#7361)
11a06de 
prove closure_closure_union and similar
@bors
Copy link

bors bot commented May 7, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(order/closure): closure of unions and bUnions [Merged by Bors] - feat(order/closure): closure of unions and bUnions May 7, 2021
@bors bors bot closed this May 7, 2021
@bors bors bot deleted the yael/closure-operators branch May 7, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamindavidson benjamindavidson benjamindavidson left review comments

@jcommelin jcommelin jcommelin approved these changes

@b-mehta b-mehta b-mehta approved these changes

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YaelDillies @eric-wieser @jcommelin @b-mehta @benjamindavidson