Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(finset/basic): downward induction for finsets #7379

Closed
wants to merge 5 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented Apr 27, 2021


Open in Gitpod

@YaelDillies YaelDillies added the awaiting-review The author would like community review of the PR label Apr 27, 2021
@YaelDillies
Copy link
Collaborator Author

I didn't manage to get an equivalent of case_strong_induction_on because we don't have such a thing as downward_induction which would use the equivalent of insert but removing an element. Any thoughts?

Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
src/data/finset/basic.lean Outdated Show resolved Hide resolved
by { dunfold strong_downward_induction_on, rw strong_downward_induction }

/-- Analogue of `strong_downward_induction_on` but over a set. -/
def strong_downward_induction_on_set {p : finset α → Sort*} {A : set (finset α)}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really necessary? We don't have analogues of this lemma for any other induction principle.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. I found it handy in my case, but it's true that it's mostly strong_downward_induction_on applied to λ s, s ∈ A → p s with s ∈ A → s.card ≤ n factored out.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, I've removed it. We'll see whether I can do without it.

src/data/finset/basic.lean Outdated Show resolved Hide resolved
src/data/finset/basic.lean Outdated Show resolved Hide resolved
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

bors bot pushed a commit that referenced this pull request May 6, 2021
@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 6, 2021
@bors
Copy link

bors bot commented May 6, 2021

This PR was included in a batch that was canceled, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 6, 2021
@bors
Copy link

bors bot commented May 6, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request May 7, 2021
bors bot pushed a commit that referenced this pull request May 7, 2021
@bors
Copy link

bors bot commented May 7, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(finset/basic): downward induction for finsets [Merged by Bors] - feat(finset/basic): downward induction for finsets May 7, 2021
@bors bors bot closed this May 7, 2021
@bors bors bot deleted the yael/finset-downward-induction branch May 7, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants