Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(category_theory/limits): dualizing some results #7391

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - feat(category_theory/limits): dualizing some results #7391

wants to merge 5 commits into from

Conversation

semorrison
Copy link
Collaborator

Requested on zulip.

Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label Apr 28, 2021
@b-mehta
Copy link
Collaborator

b-mehta commented Apr 28, 2021

Thanks for filling this in, looks good to me! There's an extra constructions file in limits/shapes/constructions/finite_products_of_binary_products.lean which should be in limits/constructions/ instead (and also should be dualized, perhaps that can go in this PR too?

@semorrison
Copy link
Collaborator Author

Done.

@jcommelin jcommelin added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Apr 30, 2021
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 1, 2021
@TwoFX
Copy link
Member

TwoFX commented May 1, 2021

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 1, 2021
@bryangingechen
Copy link
Collaborator

bors crashed
bors r+

bors bot pushed a commit that referenced this pull request May 2, 2021
@semorrison
feat(category_theory/limits): dualizing some results (#7391)
6624bbe 
Requested on [zulip](https://leanprover.zulipchat.com/#narrow/stream/267928-condensed-mathematics/topic/LocallyConstant.20preserves.20colimits/near/236442281).



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 2, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(category_theory/limits): dualizing some results [Merged by Bors] - feat(category_theory/limits): dualizing some results May 2, 2021
@bors bors bot closed this May 2, 2021
@bors bors bot deleted the has_colimit_of_has_coproducts_of_has_coequalizers branch May 2, 2021 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TwoFX TwoFX TwoFX left review comments

@adamtopaz adamtopaz Awaiting requested review from adamtopaz

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@semorrison @b-mehta @TwoFX @bryangingechen @jcommelin