Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(algebra/group_power): put lemmas about order and power in their own file #7398

Closed
wants to merge 2 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented Apr 28, 2021

This means group_power/basic has fewer dependencies, making it accessible earlier in the import graph.

The first two lemmas in this basic were moved to the end of order, but otherwise lemmas have been moved without modification and kept in the same order.

The new imports added in other files are the ones needed to make this build.


Open in Gitpod

This will conflict with #7368

@github-actions github-actions bot added blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Apr 28, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

…eir own file

This means `group_power/basic` has fewer dependencies, making it accessible earlier in the import graph.

The first two lemmas in this `basic` were moved to the end of `order`, but otherwise lemmas have been copied and kept in the same order.
…roup_power

# Conflicts:
#	src/algebra/group_power/basic.lean
@eric-wieser eric-wieser force-pushed the eric-wieser/split-group_power branch from 39c0e6d to bfea112 Compare April 29, 2021 10:05
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Apr 29, 2021
@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Apr 29, 2021
@gebner
Copy link
Member

gebner commented Apr 30, 2021

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Apr 30, 2021
bors bot pushed a commit that referenced this pull request Apr 30, 2021
…eir own file (#7398)

This means `group_power/basic` has fewer dependencies, making it accessible earlier in the import graph.

The first two lemmas in this `basic` were moved to the end of `order`, but otherwise lemmas have been moved without modification and kept in the same order.

The new imports added in other files are the ones needed to make this build.
@bors
Copy link

bors bot commented Apr 30, 2021

Build failed (retrying...):

@eric-wieser
Copy link
Member Author

I think this conflicts with #7140, let's see whether that one goes in before cancelling this one

@bryangingechen
Copy link
Collaborator

I think this conflicts with #7140, let's see whether that one goes in before cancelling this one

I took that one off the queue since it didn't build with master.

bors bot pushed a commit that referenced this pull request Apr 30, 2021
…eir own file (#7398)

This means `group_power/basic` has fewer dependencies, making it accessible earlier in the import graph.

The first two lemmas in this `basic` were moved to the end of `order`, but otherwise lemmas have been moved without modification and kept in the same order.

The new imports added in other files are the ones needed to make this build.
@bors
Copy link

bors bot commented May 1, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(algebra/group_power): put lemmas about order and power in their own file [Merged by Bors] - refactor(algebra/group_power): put lemmas about order and power in their own file May 1, 2021
@bors bors bot closed this May 1, 2021
@bors bors bot deleted the eric-wieser/split-group_power branch May 1, 2021 00:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants