Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/fintype/basic): add set.to_finset_range #7426

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(data/fintype/basic): add set.to_finset_range #7426

wants to merge 4 commits into from

Conversation

eric-wieser
Copy link
Member

Open in Gitpod

@eric-wieser eric-wieser added the awaiting-review The author would like community review of the PR label Apr 30, 2021
@eric-wieser @ericrbg
Update src/data/fintype/basic.lean
1446674 
Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@eric-wieser @b-mehta
Update src/data/fintype/basic.lean
4da0da0 
Co-authored-by: Bhavik Mehta <bhavikmehta8@gmail.com>
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 2, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label May 4, 2021
@eric-wieser eric-wieser mentioned this pull request May 4, 2021
Closed
@b-mehta
Copy link
Collaborator

b-mehta commented May 4, 2021

LGTM, thanks!

bors merge

bors bot pushed a commit that referenced this pull request May 4, 2021
@eric-wieser
feat(data/fintype/basic): add set.to_finset_range (#7426)
535f6c6
@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 4, 2021
@bors
Copy link

bors bot commented May 4, 2021

This PR was included in a batch that timed out, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 4, 2021
@eric-wieser
feat(data/fintype/basic): add set.to_finset_range (#7426)
c45ceb7
@bors
Copy link

bors bot commented May 5, 2021

This PR was included in a batch that timed out, it will be automatically retried

bors bot pushed a commit that referenced this pull request May 5, 2021
@eric-wieser
feat(data/fintype/basic): add set.to_finset_range (#7426)
4336fba
bors bot pushed a commit that referenced this pull request May 5, 2021
@eric-wieser
feat(data/fintype/basic): add set.to_finset_range (#7426)
9b1b854
@bors
Copy link

bors bot commented May 5, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/fintype/basic): add set.to_finset_range [Merged by Bors] - feat(data/fintype/basic): add set.to_finset_range May 5, 2021
@bors bors bot closed this May 5, 2021
@bors bors bot deleted the eric-wieser/set.to_finset_range branch May 5, 2021 18:50
Vierkantor pushed a commit that referenced this pull request May 6, 2021
@eric-wieser @Vierkantor
feat(data/fintype/basic): add set.to_finset_range (#7426)
6264e55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@b-mehta b-mehta b-mehta left review comments

@ericrbg ericrbg ericrbg left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eric-wieser @b-mehta @ericrbg