[Merged by Bors] - refactor(group_theory/perm/*): disjoint and support in own file #7450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
pechersky
added
the
awaiting-review
awainverse
approved these changes
May 3, 2021
|
I can keep updating this PR if those get merged first, or we can try to
merge this quickly.
…On Mon, May 3, 2021 at 6:56 PM Aaron Anderson ***@***.***> wrote:
***@***.**** approved this pull request.
Splitting this is definitely a good idea, and the few renames are also
good. It'll conflict with every other permutation PR though, so it may take
some care on the part of the maintainers.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7450 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIYHBRNE7X4LCHINBUJAZDTL4SZPANCNFSM44BTTR7Q>
.
|
tb65536
approved these changes
May 3, 2021
|
I took that description basically from the disjoint docstring below. I've
pushed a commit clarifying it.
…On Mon, May 3, 2021 at 7:10 PM tb65536 ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In src/group_theory/perm/support.lean
<#7450 (comment)>
:
> +* `equiv.perm.disjoint`: two permutations `f` and `g` are `disjoint` iff their `support`
+ are disjoint.
This sounds like a description of disjoint_iff_disjoint_support, rather
than a definition of disjoint.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#7450 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABIYHBUAOQPBCINPHE2CEUDTL4UODANCNFSM44BTTR7Q>
.
|
eric-wieser
reviewed
May 4, 2021
eric-wieser
reviewed
May 4, 2021
eric-wieser
reviewed
May 4, 2021
Vierkantor
approved these changes
May 7, 2021
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 7, 2021
The group_theory/perm/sign file was getting large and too broad in scope. This refactor pulls out `perm.support`, `perm.is_swap`, and `perm.disjoint` into a separate file. A simpler version of #7118.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The group_theory/perm/sign file was getting large and too broad in scope. This refactor pulls out
perm.support,perm.is_swap, andperm.disjointinto a separate file.A simpler version of #7118.