[Merged by Bors] - feat(algebra/module/basic): smul_add_hom_one #7461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jcommelin
commented
May 4, 2021
jcommelin
commented
jcommelin
added
the
awaiting-review
eric-wieser
reviewed
May 4, 2021
src/algebra/module/basic.lean
Outdated
| def cast_add_hom' (a : A) : ℕ →+ A := | ||
| { to_fun := λ n, n • a, | ||
| map_zero' := zero_smul _ _, | ||
| map_add' := λ m n, add_smul m n a } |
There was a problem hiding this comment.
Isn't this smul_add_hom ℕ A a or similar?
There was a problem hiding this comment.
Good point. Turns out you also need a flip. Not sure if these are worth keeping, or that I should just use the (smul_add_hom _ _).flip directly.
There was a problem hiding this comment.
I think they're probably not worth keeping as is. If this comes up often you could probably come up with a nicer name for (smul_add_hom R M).flip, but I don't think the special cases for int and nat are useful.
|
Okido, thanks for pointing to |
jcommelin
changed the title
eric-wieser
reviewed
May 4, 2021
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.