Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat/cast): pi.coe_nat and pi.nat_apply #7492

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(data/nat/cast): pi.coe_nat and pi.nat_apply #7492

wants to merge 2 commits into from

Conversation

jcommelin
Copy link
Member

Open in Gitpod

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label May 4, 2021
eric-wieser
eric-wieser reviewed May 4, 2021
View reviewed changes
src/data/nat/cast.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser reviewed May 4, 2021
View reviewed changes
src/data/nat/cast.lean Outdated Show resolved Hide resolved
eric-wieser
eric-wieser approved these changes May 4, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding the int and rat versions too while you're here?

eric-wieser
eric-wieser reviewed May 4, 2021
View reviewed changes
src/data/nat/cast.lean

variables {α β : Type*}

lemma nat_apply [has_zero β] [has_one β] [has_add β] :
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
lemma nat_apply [has_zero β] [has_one β] [has_add β] :
@[simp]
lemma nat_apply [has_zero β] [has_one β] [has_add β] :

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the coe version already takes care of this.

@semorrison semorrison added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 6, 2021
@jcommelin
Copy link
Member Author

Is it worth adding the int and rat versions too while you're here?

I've added the int version. For rat you would need a division_ring on the pi, which you don't have in general. So I left the rat version out.

@jcommelin jcommelin added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 6, 2021
Vierkantor
Vierkantor approved these changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 7, 2021
bors bot pushed a commit that referenced this pull request May 7, 2021
@jcommelin
feat(data/nat/cast): pi.coe_nat and pi.nat_apply (#7492)
565310f
@bors
Copy link

bors bot commented May 7, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/cast): pi.coe_nat and pi.nat_apply [Merged by Bors] - feat(data/nat/cast): pi.coe_nat and pi.nat_apply May 7, 2021
@bors bors bot closed this May 7, 2021
@bors bors bot deleted the pi-coe-nat branch May 7, 2021 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcommelin @eric-wieser @Vierkantor @semorrison