Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(field_theory/abel_ruffini): Version of solvable_by_rad.is_solvable #7509

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(field_theory/abel_ruffini): Version of solvable_by_rad.is_solvable #7509

wants to merge 3 commits into from

Conversation

tb65536
Copy link
Collaborator

@tb65536 tb65536 commented May 5, 2021 •
edited

This is a version of solvable_by_rad.is_solvable, which will be the final step of the abel-ruffini theorem.

Open in Gitpod

@tb65536 tb65536 added the awaiting-review The author would like community review of the PR label May 5, 2021
@tb65536 tb65536 changed the title feat(field_theory/abel_ruffini): contrapositive version of solvable_by_rad.is_solvable feat(field_theory/abel_ruffini): Version of solvable_by_rad.is_solvable May 6, 2021
jcommelin
jcommelin reviewed May 7, 2021
View reviewed changes
src/field_theory/abel_ruffini.lean Outdated Show resolved Hide resolved
src/field_theory/abel_ruffini.lean Outdated Show resolved Hide resolved
@tb65536 tb65536 added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 7, 2021
@tb65536 tb65536 added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 7, 2021
@tb65536 tb65536 mentioned this pull request May 10, 2021
Closed
3 tasks
jcommelin
jcommelin approved these changes May 10, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 10, 2021
bors bot pushed a commit that referenced this pull request May 10, 2021
@tb65536
feat(field_theory/abel_ruffini): Version of solvable_by_rad.is_solvab…
38bf2ab 
…le (#7509)

This is a version of `solvable_by_rad.is_solvable`, which will be the final step of the abel-ruffini theorem.
@bors
Copy link

bors bot commented May 10, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(field_theory/abel_ruffini): Version of solvable_by_rad.is_solvable [Merged by Bors] - feat(field_theory/abel_ruffini): Version of solvable_by_rad.is_solvable May 10, 2021
@bors bors bot closed this May 10, 2021
@bors bors bot deleted the is_solvable_contrapositive branch May 10, 2021 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcommelin jcommelin jcommelin approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tb65536 @jcommelin