[Merged by Bors] - refactor(algebra/module): rename smul_injective hx to smul_left_injective M hx
#7577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…jective M hx` This is a follow-up PR to #7548. * Now that there is also a `smul_right_injective`, we should disambiguate the previous `smul_injective` to `smul_left_injective`. * The `M` parameter can't be inferred from arguments before the colon, so we make it explicit.
Vierkantor
added
the
awaiting-review
eric-wieser
approved these changes
May 11, 2021
Good point. The assumptions are orthogonal enough though, that there is no easy way to unify them. |
|
bors d+ |
|
✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
Whoops, forgot to commit the fix before pushing this branch and creating the PR :P |
bors bot
pushed a commit
that referenced
this pull request
May 12, 2021
…jective M hx` (#7577) This is a follow-up PR to #7548. * Now that there is also a `smul_right_injective`, we should disambiguate the previous `smul_injective` to `smul_left_injective`. * The `M` parameter can't be inferred from arguments before the colon, so we make it explicit in `smul_left_injective` and `smul_right_injective`.
github-actions
bot
added
the
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
smul_injective hx to smul_left_injective M hxsmul_injective hx to smul_left_injective M hx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up PR to #7548.
smul_right_injective, we should disambiguate the previoussmul_injectivetosmul_left_injective.Mparameter can't be inferred from arguments before the colon, so we make it explicit insmul_left_injectiveandsmul_right_injective.