[Merged by Bors] - feat(tactic/simps): implement prefix names #7596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpvandoorn
added
awaiting-author
fpvandoorn
added
awaiting-review
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
Vierkantor
approved these changes
May 17, 2021
eric-wieser
reviewed
May 17, 2021
eric-wieser
reviewed
May 17, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 26, 2021
* You can now write `initialize_simps_projections equiv (to_fun → coe as_prefix)` to add the projection name as a prefix to the simp lemmas: if you then write `@[simps coe] def foo ...` you get a lemma named `coe_foo`. * Remove the `short_name` option from `simps_cfg`. This was unused and not that useful. * Refactor some tuples used in the functions into structures. * Implements one item of #5489.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initialize_simps_projections equiv (to_fun → coe as_prefix)to add the projection name as a prefix to the simp lemmas: if you then write@[simps coe] def foo ...you get a lemma namedcoe_foo.short_nameoption fromsimps_cfg. This was unused and not that useful.Requested by @b-mehta and @eric-wieser