Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(topology/algebra/ordered): reduce imports #7601

Closed
wants to merge 4 commits into from

Conversation

semorrison
Copy link
Collaborator

Renames topology.algebra.ordered to topology.algebra.order, and moves the material about liminf/limsup and about extend_from to separate files, in order to delay imports.


Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 13, 2021
@fpvandoorn
Copy link
Member

I'm used to default.lean usually importing all files in that directory, and basic.lean containing the basic definitions. So I would expect topology/algebra/order/default.lean to be called topology/algebra/order/basic.lean.
But I believe this is not a (hard) rule in mathlib, so I can also live with this choice.

@PatrickMassot
Copy link
Member

I think the new file name is pretty confusing because we already have topology/order which is about the order on tolopological_space X for any X whereas topology/algebra/ordered is about topological_space X assuming X is ordered. I'm not saying the names are great, but having different names seems reasonable.

@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels May 14, 2021
@semorrison
Copy link
Collaborator Author

I've switched back to ordered per @PatrickMassot's suggestion, and renamed default.lean to basic.lean.

(I might argue that we should get rid of all our "default imports everything" files, but not here.)

@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels May 14, 2021
@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels May 14, 2021
bors bot pushed a commit that referenced this pull request May 14, 2021
Renames `topology.algebra.ordered` to `topology.algebra.order`, and moves the material about `liminf/limsup` and about `extend_from` to separate files, in order to delay imports.



Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@bors
Copy link

bors bot commented May 14, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(topology/algebra/ordered): reduce imports [Merged by Bors] - refactor(topology/algebra/ordered): reduce imports May 14, 2021
@bors bors bot closed this May 14, 2021
@bors bors bot deleted the slice_topology_algebra_ordered branch May 14, 2021 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants