[Merged by Bors] - feat(logic/is_empty): Add is_empty typeclass #7606
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…equiv that stopped tc inference from firing. Have a linter for this?
fpvandoorn
added
awaiting-review
|
Build has passed, this can be reviewed while I make the linter happy. |
github-actions
bot
added
the
merge-conflict
github-actions
bot
removed
the
merge-conflict
|
Very nice, thank you. No comments. :-) bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 18, 2021
* Refactor some equivalences that use `empty` or `pempty`. * Replace `α → false` with `is_empty α` in various places (but not everywhere, we can do that in follow-up PRs). * `infinite` is now defined as `is_empty (fintype α)`. The old `not_fintype` is renamed to `fintype.false` (to allow projection notation), and there are two useful variants `infinite.false` and `not_fintype` added with different arguments explicit. * add instance `unique true`. * Changed the type of `fin_one_equiv` from `fin 1 ≃ punit` to `fin 1 ≃ unit` (it was used only once, where the former formulation required giving an explicit universe level). * renamings: `equiv.subsingleton_iff` -> `equiv.subsingleton_congr` `finprod_of_empty` -> `finprod_of_is_empty`
|
Build failed (retrying...): |
bors bot
pushed a commit
that referenced
this pull request
May 18, 2021
* Refactor some equivalences that use `empty` or `pempty`. * Replace `α → false` with `is_empty α` in various places (but not everywhere, we can do that in follow-up PRs). * `infinite` is proven equivalent to `is_empty (fintype α)`. The old `not_fintype` is renamed to `fintype.false` (to allow projection notation), and there are two useful variants `infinite.false` and `not_fintype` added with different arguments explicit. * add instance `unique true`. * Changed the type of `fin_one_equiv` from `fin 1 ≃ punit` to `fin 1 ≃ unit` (it was used only once, where the former formulation required giving an explicit universe level). * renamings: `equiv.subsingleton_iff` -> `equiv.subsingleton_congr` `finprod_of_empty` -> `finprod_of_is_empty`
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Vierkantor
pushed a commit
that referenced
this pull request
May 19, 2021
* Refactor some equivalences that use `empty` or `pempty`. * Replace `α → false` with `is_empty α` in various places (but not everywhere, we can do that in follow-up PRs). * `infinite` is proven equivalent to `is_empty (fintype α)`. The old `not_fintype` is renamed to `fintype.false` (to allow projection notation), and there are two useful variants `infinite.false` and `not_fintype` added with different arguments explicit. * add instance `unique true`. * Changed the type of `fin_one_equiv` from `fin 1 ≃ punit` to `fin 1 ≃ unit` (it was used only once, where the former formulation required giving an explicit universe level). * renamings: `equiv.subsingleton_iff` -> `equiv.subsingleton_congr` `finprod_of_empty` -> `finprod_of_is_empty`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
emptyorpempty.α → falsewithis_empty αin various places (but not everywhere, we can do that in follow-up PRs).infiniteis proven equivalent tois_empty (fintype α). The oldnot_fintypeis renamed tofintype.false(to allow projection notation), and there are two useful variantsinfinite.falseandnot_fintypeadded with different arguments explicit.unique true.fin_one_equivfromfin 1 ≃ punittofin 1 ≃ unit(it was used only once, where the former formulation required giving an explicit universe level).equiv.subsingleton_iff->equiv.subsingleton_congrfinprod_of_empty->finprod_of_is_empty