refactor(algebra/group): generalise and extend the API for with_zero #762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's not obvious what's changed here. Can you give a summary? |
|
(1) Before this patch, you don't automatically have an instance of |
anrddh
pushed a commit
to anrddh/mathlib
that referenced
this pull request
May 15, 2020
…eanprover-community#762) * refactor(algebra/group): generalise and extend the API for with_zero * Shorter proof. Thanks Chris * Travis, try your best
YaelDillies
added a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 22, 2024
Everything under `Algebra.Group` should be additivisable. Therefore I move the `GroupWithZero` instances for `WithZero` from `Algebra.Group.WithOne.Defs` and the whole of `Algebra.Group.WithOne.Units` to a new file `Algebra.GroupWithZero.WithZero`. I credit Mario for leanprover-community/mathlib@ad92a9b and Johan for leanprover-community/mathlib#762.
mathlib-bors bot
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 23, 2024
Everything under `Algebra.Group` should be additivisable. Therefore I move the `GroupWithZero` instances for `WithZero` from `Algebra.Group.WithOne.Defs` and the whole of `Algebra.Group.WithOne.Units` to a new file `Algebra.GroupWithZero.WithZero`. I credit Mario for leanprover-community/mathlib@ad92a9b and Johan for leanprover-community/mathlib#762. Use the opportunity to slightly clean up the code: * Replace `:=` by `where` in instance declarations * Add missing explicit arguments to `coe` lemmas * Add missing `section ... end`
Jun2M
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
Apr 24, 2024
Everything under `Algebra.Group` should be additivisable. Therefore I move the `GroupWithZero` instances for `WithZero` from `Algebra.Group.WithOne.Defs` and the whole of `Algebra.Group.WithOne.Units` to a new file `Algebra.GroupWithZero.WithZero`. I credit Mario for leanprover-community/mathlib@ad92a9b and Johan for leanprover-community/mathlib#762. Use the opportunity to slightly clean up the code: * Replace `:=` by `where` in instance declarations * Add missing explicit arguments to `coe` lemmas * Add missing `section ... end`
callesonne
pushed a commit
to leanprover-community/mathlib4
that referenced
this pull request
May 16, 2024
Everything under `Algebra.Group` should be additivisable. Therefore I move the `GroupWithZero` instances for `WithZero` from `Algebra.Group.WithOne.Defs` and the whole of `Algebra.Group.WithOne.Units` to a new file `Algebra.GroupWithZero.WithZero`. I credit Mario for leanprover-community/mathlib@ad92a9b and Johan for leanprover-community/mathlib#762. Use the opportunity to slightly clean up the code: * Replace `:=` by `where` in instance declarations * Add missing explicit arguments to `coe` lemmas * Add missing `section ... end`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TO CONTRIBUTORS:
Make sure you have:
For reviewers: code review check list