Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - refactor(algebra/homology/homotopy): avoid needing has_zero_object #7621

Closed
wants to merge 4 commits into from

Conversation

semorrison
Copy link
Collaborator

@semorrison semorrison commented May 16, 2021

A refactor of the definition of homotopy, so we don't need has_zero_object.

Co-authored-by: Adam Topaz github@adamtopaz.com


Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 16, 2021
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors d+

src/algebra/homology/homotopy.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented May 17, 2021

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels May 17, 2021
@semorrison
Copy link
Collaborator Author

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 17, 2021
bors bot pushed a commit that referenced this pull request May 17, 2021
…7621)

A refactor of the definition of `homotopy`, so we don't need `has_zero_object`.

Co-authored-by: Adam Topaz github@adamtopaz.com



Co-authored-by: Adam Topaz <github@adamtopaz.com>
Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
Co-authored-by: Johan Commelin <johan@commelin.net>
@bors
Copy link

bors bot commented May 17, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title refactor(algebra/homology/homotopy): avoid needing has_zero_object [Merged by Bors] - refactor(algebra/homology/homotopy): avoid needing has_zero_object May 17, 2021
@bors bors bot closed this May 17, 2021
@bors bors bot deleted the homotopy_fix branch May 17, 2021 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants