Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory/sub{group,monoid,semiring,ring}): subobjects inherit the actions of their carrier type #7665

Closed
wants to merge 6 commits into from

Conversation

eric-wieser
Copy link
Member

@eric-wieser eric-wieser commented May 19, 2021

This acts as a generalization of algebra.of_subsemiring and algebra.of_subring, and transfers the weaker action structures too.


Open in Gitpod

@semorrison semorrison added the awaiting-review The author would like community review of the PR label May 20, 2021
@eric-wieser eric-wieser changed the title feat(group_theory/sub{group,monoid}): subgroups and submonoid inherit the actions of their carrier type feat(group_theory/sub{group,monoid,semiring,ring}): subobjects inherit the actions of their carrier type May 20, 2021
@eric-wieser
Copy link
Member Author

The actions here are very similar to those in #7438 - mind taking a look @fpvandoorn?

@bors
Copy link

bors bot commented May 25, 2021

✌️ eric-wieser can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bors d+

src/ring_theory/subsemiring.lean Outdated Show resolved Hide resolved
@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels May 25, 2021
src/ring_theory/subsemiring.lean Outdated Show resolved Hide resolved
src/ring_theory/subring.lean Outdated Show resolved Hide resolved
@eric-wieser
Copy link
Member Author

bors r+

Last commit was just docstrings, and the style linter passed

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label May 26, 2021
bors bot pushed a commit that referenced this pull request May 26, 2021
…t the actions of their carrier type (#7665)

This acts as a generalization of `algebra.of_subsemiring` and `algebra.of_subring`, and transfers the weaker action structures too.
@bors
Copy link

bors bot commented May 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/sub{group,monoid,semiring,ring}): subobjects inherit the actions of their carrier type [Merged by Bors] - feat(group_theory/sub{group,monoid,semiring,ring}): subobjects inherit the actions of their carrier type May 26, 2021
@bors bors bot closed this May 26, 2021
@bors bors bot deleted the eric-wieser/subgroup-mul_action branch May 26, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants