Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(data/equiv): add docstrings #7704

Closed
wants to merge 10 commits into from
Closed

[Merged by Bors] - chore(data/equiv): add docstrings #7704

wants to merge 10 commits into from

Conversation

YaelDillies
Copy link
Collaborator

@YaelDillies YaelDillies commented May 24, 2021 •
edited

  • add module docstrings
  • add def docstrings
  • rename decode2 to decode₂
  • squash some simps

Open in Gitpod

@YaelDillies YaelDillies added the WIP Work in progress label May 24, 2021
bryangingechen
bryangingechen reviewed May 24, 2021
View reviewed changes
scripts/nolints.txt Outdated Show resolved Hide resolved
@YaelDillies
Copy link
Collaborator Author

I'm also changing data/equiv/basic, data/equiv/nat, data/equiv/list. Should I add them to this PR or do you prefer me creating other ones?

@bryangingechen
Copy link
Collaborator

I'm also changing data/equiv/basic, data/equiv/nat, data/equiv/list. Should I add them to this PR or do you prefer me creating other ones?

Either way is fine, though I'd say if they're truly independent, it's better to make multiple PRs for easier review.

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed WIP Work in progress labels May 27, 2021
sgouezel
sgouezel reviewed May 31, 2021
View reviewed changes
src/data/equiv/encodable/basic.lean Outdated Show resolved Hide resolved
src/data/equiv/encodable/basic.lean Show resolved Hide resolved
src/data/equiv/encodable/basic.lean Show resolved Hide resolved
sgouezel
sgouezel reviewed Jun 2, 2021
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+
Thanks!

src/data/equiv/denumerable.lean Outdated Show resolved Hide resolved
src/data/equiv/denumerable.lean Outdated Show resolved Hide resolved
src/data/equiv/encodable/basic.lean Outdated Show resolved Hide resolved
src/data/equiv/encodable/basic.lean Outdated Show resolved Hide resolved
src/data/equiv/encodable/basic.lean Outdated Show resolved Hide resolved
src/data/equiv/encodable/basic.lean Outdated Show resolved Hide resolved
src/data/equiv/encodable/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 2, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 2, 2021
@YaelDillies @sgouezel
minor changes
4e8488a 
Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 2, 2021
@YaelDillies
chore(data/equiv): add docstrings (#7704)
cce5f98 
- add module docstrings
- add def docstrings
- rename `decode2` to `decode₂`
- squash some simps
@bors
Copy link

bors bot commented Jun 2, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jun 2, 2021
@YaelDillies
chore(data/equiv): add docstrings (#7704)
7e3e883 
- add module docstrings
- add def docstrings
- rename `decode2` to `decode₂`
- squash some simps
@bors
Copy link

bors bot commented Jun 3, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/equiv): add docstrings [Merged by Bors] - chore(data/equiv): add docstrings Jun 3, 2021
@bors bors bot closed this Jun 3, 2021
@bors bors bot deleted the yael/data/equiv branch June 3, 2021 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@bryangingechen bryangingechen bryangingechen left review comments

@sgouezel sgouezel sgouezel left review comments

@ericrbg ericrbg ericrbg left review comments

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@YaelDillies @bryangingechen @eric-wieser @sgouezel @ericrbg