[Merged by Bors] - feat(geometry/manifold): derivation_bundle
#7708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nicknamen
changed the title
derivation_bundle
eric-wieser
reviewed
Jun 23, 2021
eric-wieser
reviewed
Jun 23, 2021
eric-wieser
reviewed
Jun 23, 2021
eric-wieser
reviewed
Jun 23, 2021
eric-wieser
reviewed
Jun 23, 2021
eric-wieser
reviewed
Jun 23, 2021
eric-wieser
reviewed
Jun 23, 2021
Nicknamen
commented
Jun 23, 2021
Nicknamen
force-pushed
the
Lie_group_algebra
branch
from
48f2b66
to
000c764
Compare
Eric's suggestions Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Nicknamen
force-pushed
the
Lie_group_algebra
branch
from
000c764
to
90eae14
Compare
Nicknamen
commented
Jun 24, 2021
jcommelin
reviewed
Jun 28, 2021
|
|
||
| /-- Type synonym, introduced to put a different `has_scalar` action on `C^n⟮I, M; 𝕜⟯` | ||
| which is defined as `f • r = f(x) * r`. -/ | ||
| @[nolint unused_arguments] def pointed_smooth_map (x : M) := C^n⟮I, M; 𝕜⟯ |
There was a problem hiding this comment.
It's not clear to me that this case will never be explored. I have a slight preference for the pointed_times name.
ocfnash
reviewed
Jun 28, 2021
|
If you fix the things that I flagged in the comments above, then this is ready for merging. |
Co-authored-by: Oliver Nash <github@olivernash.org> Co-authored-by: Johan Commelin <johan@commelin.net>
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 28, 2021
In this PR we define the `derivation_bundle`. Note that this definition is purely algebraic and that the whole geometry/analysis is contained in the algebra structure of smooth global functions on the manifold. I believe everything runs smoothly and elegantly and that most proofs can be naturally done by `rfl`. To anticipate some discussions that already arose on Zulip about 9 months ago, note that the content of these files is purely algebraic and that there is no intention whatsoever to replace the current tangent bundle. I prefer this definition to the one given through the adjoint representation, because algebra is more easily formalized and simp can solve most proofs with this definition. However, in the future, there will be also the adjoint representation for sure.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
derivation_bundlederivation_bundle
b-mehta
pushed a commit
that referenced
this pull request
Jul 6, 2021
In this PR we define the `derivation_bundle`. Note that this definition is purely algebraic and that the whole geometry/analysis is contained in the algebra structure of smooth global functions on the manifold. I believe everything runs smoothly and elegantly and that most proofs can be naturally done by `rfl`. To anticipate some discussions that already arose on Zulip about 9 months ago, note that the content of these files is purely algebraic and that there is no intention whatsoever to replace the current tangent bundle. I prefer this definition to the one given through the adjoint representation, because algebra is more easily formalized and simp can solve most proofs with this definition. However, in the future, there will be also the adjoint representation for sure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we define the
derivation_bundle. Note that this definition is purely algebraic and that the whole geometry/analysis is contained in the algebra structure of smooth global functions on the manifold.I believe everything runs smoothly and elegantly and that most proofs can be naturally done by
rfl. To anticipate some discussions that already arose on Zulip about 9 months ago, note that the content of these files is purely algebraic and that there is no intention whatsoever to replace the current tangent bundle. I prefer this definition to the one given through the adjoint representation, because algebra is more easily formalized and simp can solve most proofs with this definition. However, in the future, there will be also the adjoint representation for sure.