[Merged by Bors] - chore(data/fintype/basic): fintype α/β from fintype α ⊕ β
#7736
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericrbg
added
awaiting-review
eric-wieser
reviewed
May 28, 2021
ericrbg
commented
May 28, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
|
bors merge |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
May 30, 2021
Also renaming the equivalent `α × β` versions, for consistency. Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
fintype α/β from fintype α ⊕ βfintype α/β from fintype α ⊕ β
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also renaming the equivalent
α × βversions, for consistency.I don't see a clear way to make this computable without
inhabited α, and if you haveinhabited αandfintype α ⊕ βI would be shocked if you didn't havefintype αalready. Not aninstancefor typeclass-looping reasons.(The issue with
equiv.of_left_inverseis that I needinhabited, notnonempty)