Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/ordered_group): -abs a ≤ a #7839

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(algebra/ordered_group): -abs a ≤ a #7839

wants to merge 2 commits into from

Conversation

benjamindavidson
Copy link
Collaborator

No description provided.

@benjamindavidson benjamindavidson added the awaiting-review The author would like community review of the PR label Jun 8, 2021
@digama0
Copy link
Member

digama0 commented Jun 8, 2021 •
edited

We don't normally have lemmas that are conjunctions of other lemmas (unless proving the conjunction is easier for some reason than proving the parts, in which case it's usually an auxiliary lemma and the parts are separated immediately after). I would just keep the first lemma.

eric-wieser
eric-wieser approved these changes Jun 8, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 8, 2021
bors bot pushed a commit that referenced this pull request Jun 8, 2021
@benjamindavidson
feat(algebra/ordered_group): -abs a ≤ a ≤ abs a (#7839)
b6bc20f
@eric-wieser eric-wieser changed the title feat(algebra/ordered_group): -abs a ≤ a ≤ abs a feat(algebra/ordered_group): -abs a ≤ a Jun 8, 2021
@eric-wieser
Copy link
Member

The failing CI run looks like it's a CDN issue unrelated to this PR. It's still quite likely bors will trip up on the same thing, but there's not much we can do about that anyway.

@bors
Copy link

bors bot commented Jun 8, 2021

This PR was included in a batch that timed out, it will be automatically retried

@sgouezel
Copy link
Collaborator

sgouezel commented Jun 9, 2021

bors r-

@bors
Copy link

bors bot commented Jun 9, 2021

Canceled.

@sgouezel
Copy link
Collaborator

sgouezel commented Jun 9, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jun 9, 2021
@benjamindavidson
feat(algebra/ordered_group): -abs a ≤ a (#7839)
764e878
@bors
Copy link

bors bot commented Jun 9, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ordered_group): -abs a ≤ a [Merged by Bors] - feat(algebra/ordered_group): -abs a ≤ a Jun 9, 2021
@bors bors bot closed this Jun 9, 2021
@bors bors bot deleted the neg_abs_le branch June 9, 2021 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@benjamindavidson @digama0 @eric-wieser @sgouezel