[Merged by Bors] - feat(algebra/non_unital_alg_hom): define non_unital_alg_hom #7863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The motivation is to be able to state the universal property for a magma algebra using bundled morphisms.
The plan is to split this PR in two since the other changes are deep and cause long build times.
This reverts commit 880e44b.
github-actions
bot
added
the
blocked-by-other-PR
ocfnash
changed the title
ocfnash
added
the
awaiting-review
github-actions
bot
added
merge-conflict
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
github-actions
bot
removed
the
merge-conflict
ocfnash
commented
Jun 12, 2021
I missed this when I generalised from extending linear_map to extending distrib_mul_action_hom
Missed these in earlier work.
|
This all looks very uncontroversial. Maybe you should say something about planned usage of this structure in the module docstring? |
kbuzzard
approved these changes
Jun 18, 2021
eric-wieser
approved these changes
Jun 21, 2021
|
✌️ ocfnash can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
bors bot
pushed a commit
that referenced
this pull request
Jun 21, 2021
The motivation is to be able to state the universal property for a magma algebra using bundled morphisms.
|
bors r- |
|
Canceled. |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jun 21, 2021
The motivation is to be able to state the universal property for a magma algebra using bundled morphisms.
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to be able to state the universal property for a magma algebra using bundled morphisms.
If we merge this, then I should be able to drop #6591 completely.
inversedefs #7847