[Merged by Bors] - feat(analysis/normed_space/normed_group_hom): add lemmas #7875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
riccardobrasca
added
the
awaiting-review
riccardobrasca
commented
Jun 10, 2021
| @@ -281,6 +281,8 @@ variables {f g} | |||
|
|
|||
| /-! ### The identity normed group hom -/ | |||
|
|
|||
| variable (V) | |||
There was a problem hiding this comment.
It seems more reasonable to me to have V explicit in the definition of normed_group_hom.id, but I am not 100% sure.
jcommelin
reviewed
Jun 10, 2021
| (h.comp g).comp f = h.comp (g.comp f) := | ||
| by { ext, refl } | ||
|
|
||
| lemma coe_comp (f : normed_group_hom V₁ V₂) (g : normed_group_hom V₂ V₃) : |
There was a problem hiding this comment.
Should this be a simp-lemma?
Suggested change
| lemma coe_comp (f : normed_group_hom V₁ V₂) (g : normed_group_hom V₂ V₃) : | |
| @[simp] lemma coe_comp (f : normed_group_hom V₁ V₂) (g : normed_group_hom V₂ V₃) : |
There was a problem hiding this comment.
I went back to the non simp version since the linter was not happy: normed_group_hom.comp_apply (that is autogenerated) is not in simp normal form.
Co-authored-by: Johan Commelin <johan@commelin.net>
github-actions
bot
added
ready-to-merge
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From LTE.