Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(linear_algebra/invariant_basis_number): basic API lemmas #7882

Closed
wants to merge 18 commits into from
Closed

[Merged by Bors] - feat(linear_algebra/invariant_basis_number): basic API lemmas #7882

wants to merge 18 commits into from

Conversation

semorrison
Copy link
Collaborator

Open in Gitpod

@Ruben-VandeVelde Ruben-VandeVelde added the awaiting-author A reviewer has asked the author a question or requested changes label Jun 10, 2021
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 16, 2021
@semorrison semorrison mentioned this pull request Jul 17, 2021
Closed
7 tasks
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 18, 2021
@semorrison semorrison added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 19, 2021
Vierkantor
Vierkantor approved these changes Jul 22, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

src/algebra/module/linear_map.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 22, 2021

✌️ semorrison can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 22, 2021
@semorrison @Vierkantor
Update src/algebra/module/linear_map.lean
2826897 
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@semorrison
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Aug 13, 2021
@semorrison
feat(linear_algebra/invariant_basis_number): basic API lemmas (#7882)
d0804ba 


Co-authored-by: Scott Morrison <scott.morrison@gmail.com>
@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Aug 13, 2021
@bors
Copy link

bors bot commented Aug 13, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/invariant_basis_number): basic API lemmas [Merged by Bors] - feat(linear_algebra/invariant_basis_number): basic API lemmas Aug 13, 2021
@bors bors bot closed this Aug 13, 2021
@bors bors bot deleted the ibn_lemmas branch August 13, 2021 06:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@semorrison @eric-wieser @Vierkantor @Ruben-VandeVelde