Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - doc(topology/algebra/ring): add module docs + tidy #7893

Closed
wants to merge 8 commits into from
Closed

[Merged by Bors] - doc(topology/algebra/ring): add module docs + tidy #7893

wants to merge 8 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Jun 11, 2021

Ignore the silly original commit title. I'm still unsure about quotient_ring_saturate's name, and also whether I should add docs to quotient_ring.quotient_map_coe_coe

Open in Gitpod

@ericrbg ericrbg changed the title feat(topology/algebra/ring): add module docs doc(topology/algebra/ring): add module docs Jun 11, 2021
@ericrbg ericrbg added the awaiting-review The author would like community review of the PR label Jun 12, 2021
@ericrbg ericrbg changed the title doc(topology/algebra/ring): add module docs doc(topology/algebra/ring): add module docs + tidy Jun 12, 2021
PatrickMassot
PatrickMassot reviewed Jun 13, 2021
View reviewed changes
src/topology/algebra/ring.lean Outdated Show resolved Hide resolved
src/topology/algebra/ring.lean Outdated Show resolved Hide resolved
src/topology/algebra/ring.lean Outdated Show resolved Hide resolved
src/topology/algebra/ring.lean Outdated Show resolved Hide resolved
@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 13, 2021
ericrbg and others added 2 commits June 13, 2021 18:37
@ericrbg @PatrickMassot
Apply suggestions from code review
1d1253c 
Co-authored-by: Patrick Massot <patrickmassot@free.fr>
@ericrbg
move quotient_ring_saturate
274255e
@ericrbg ericrbg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 13, 2021
@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 13, 2021
@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 15, 2021
@leanprover-community leanprover-community deleted a comment from bors bot Jun 15, 2021
@PatrickMassot PatrickMassot added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Jun 15, 2021
@ericrbg @kbuzzard
Kevin's suggestion
d930aa1 
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
@ericrbg ericrbg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 15, 2021
@PatrickMassot
Copy link
Member

@ericrbg could you fix that line length error please?

@ericrbg
Copy link
Collaborator Author

ericrbg commented Jun 16, 2021

oops, done!

@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 16, 2021
bors bot pushed a commit that referenced this pull request Jun 16, 2021
@ericrbg
doc(topology/algebra/ring): add module docs + tidy (#7893)
366a449 


Co-authored-by: Eric <37984851+ericrbg@users.noreply.github.com>
@bors
Copy link

bors bot commented Jun 17, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title doc(topology/algebra/ring): add module docs + tidy [Merged by Bors] - doc(topology/algebra/ring): add module docs + tidy Jun 17, 2021
@bors bors bot closed this Jun 17, 2021
@bors bors bot deleted the ericrbg/docs_topring branch June 17, 2021 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickMassot PatrickMassot PatrickMassot left review comments

@YaelDillies YaelDillies YaelDillies left review comments

@kbuzzard kbuzzard kbuzzard left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ericrbg @PatrickMassot @YaelDillies @kbuzzard