Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(data/setoid/partition): indexed partition #7910
[Merged by Bors] - feat(data/setoid/partition): indexed partition #7910
Changes from 4 commits
c04c1d7
6d83b26
c0abaaf
3b4d331
7eaaccb
4f76c2d
50696fc
5bc08d6
dd53888
6df7144
7e8e12d
8800a26
7d8532a
7bbd8cf
88a47bd
b6d21c7
d13fd21
2819f92
b37b189
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It could be nice to have the
exists_unique
version of this usingdisjoint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this whole definition golfs to
setoid.ker hs.index
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't be definitionaly equal, so all proofs will break. I don't have time to play this game.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's better here to use
setoid.ker
in this file - we have it for a reason, and it feels unnecessary to duplicate work when there's a nicer definition which also simplifies later proofs as Eric shows below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are the ones who talk about duplicating work. That file works, it is usable since it has been used without any problem. Now you want to duplicate work by redoing it differently. You are welcome do it, but I won't.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's important to distinguish duplicating effort from duplicating code. Bhavik means that the API surface of mathlib has duplication (aka, the output of the work is duplicated), while Patrick is objecting to redoing the work.
I've pushed a change to that effect, which removes 20 lines of proofs.