Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(linear_algebra/free_module): add lemmas #7950

Closed
wants to merge 19 commits into from

Conversation

riccardobrasca
Copy link
Member

Easy results about free modules.


Open in Gitpod

@riccardobrasca riccardobrasca added the awaiting-review The author would like community review of the PR label Jun 15, 2021

lemma linear_independent_std_basis [decidable_eq η]
(v : Πj, ιs j → (Ms j)) (hs : ∀i, linear_independent R (v i)) :
lemma linear_independent_std_basis [ring R] [∀i, add_comm_group (Ms i)] [∀i, module R (Ms i)]
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is essentially the same as before, i just generalized it to semiring, except linear_independent_std_basis that does not work. I didn't touch any proof.

Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

src/linear_algebra/dfinsupp.lean Outdated Show resolved Hide resolved
src/linear_algebra/dfinsupp.lean Show resolved Hide resolved
src/linear_algebra/free_module.lean Outdated Show resolved Hide resolved
src/linear_algebra/free_module.lean Outdated Show resolved Hide resolved

/-- The direct sum of free modules is free.

Note that while this is stated for `dfinsupp` not `direct_sum`, the types are defeq. -/
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why we have module instances for both dfinsupp and direct_sum? Should the second one become notation perhaps?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My mental model is that finsupp is to dfinsupp as monoid_algebra is to direct_sum.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No idea why direct_sum is a def rather than notation, but I was indeed slightly confused by this the first time I saw it.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The way I understand monoid_algebra is as a type synonym for finsupp that chooses * to be the convolution product (rather than the pointwise product). But the direct sum of modules doesn't have a product, right?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mathematically they work in different categories, monoid_algebra is the left/right (I always forget) adjoint to the forgetful functor algebras → monoids, so it is like free modules (that is the adjoint to the forgetful modules → sets). The direct sum is the coproduct in R-mod, and the analogue for algebras is tensor product.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But the direct sum of modules doesn't have a product, right?

If those modules are submodules of the same algebra, then direct_sum.ring provides a convolutional product mirroring monoid_algebra via direct_sum.gmonoid.of_submodules

@bors
Copy link

bors bot commented Jun 22, 2021

✌️ riccardobrasca can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 22, 2021
riccardobrasca and others added 4 commits June 22, 2021 13:24
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@riccardobrasca
Copy link
Member Author

bors r+

bors bot pushed a commit that referenced this pull request Jun 22, 2021
@bors
Copy link

bors bot commented Jun 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(linear_algebra/free_module): add lemmas [Merged by Bors] - feat(linear_algebra/free_module): add lemmas Jun 22, 2021
@bors bors bot closed this Jun 22, 2021
@bors bors bot deleted the free_mod_lemmas branch June 22, 2021 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants