[Merged by Bors] - docs(data/pnat): add module docstrings #7960
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't like those two files,
xgcd
in particular, for several reasons:For
xgcd
,xgcd_type
is literallyℕ × ℕ × ℕ × ℕ × ℕ × ℕ
with custom fields names. At leastis_special
could be bundled with it.nat.xgcd
(which already existed at the time of Neil Strickland's commit, feat (data/pnat): extensions to pnat #1073) but with no mention toℤ
.is_special
/is_special'
,is_reduced
/is_reduced'
), and this isn't justified bydefeq
concerns or similar.For
factors
,prime_multiset
is a subtype.Neither file is ever imported, which suggests that they are currently of limited use.
Any opinion?