Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(topology/instances/real): a continuous periodic function has compact range (and is hence bounded) #7968

Closed
wants to merge 8 commits into from

Conversation

benjamindavidson
Copy link
Collaborator

@benjamindavidson benjamindavidson commented Jun 17, 2021

A few more facts about periodic functions, namely:

  • If a function f is periodic with positive period p,
    then for all x there exists y such that y is an element of [0, p) and f x = f y
  • A continuous, periodic function has compact range
  • A continuous, periodic function is bounded

Open in Gitpod

@benjamindavidson benjamindavidson added the awaiting-review The author would like community review of the PR label Jun 17, 2021
src/topology/metric_space/basic.lean Outdated Show resolved Hide resolved
src/topology/metric_space/basic.lean Outdated Show resolved Hide resolved
@hrmacbeth
Copy link
Member

On second thoughts, I think the main lemmas here should go in topology.instances.real, not topology.metric_space.basic.

@benjamindavidson benjamindavidson changed the title feat(topology/metric_space/basic): a continuous periodic function is compact (and hence bounded) feat(topology/instances/real): a continuous periodic function has compact range (and is hence bounded) Jun 18, 2021
@hrmacbeth
Copy link
Member

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 20, 2021
bors bot pushed a commit that referenced this pull request Jun 20, 2021
…pact range (and is hence bounded) (#7968)

A few more facts about periodic functions, namely:
- If a function `f` is `periodic` with positive period `p`,
  then for all `x` there exists `y` such that `y` is an element of `[0, p)` and `f x = f y`
- A continuous, periodic function has compact range
- A continuous, periodic function is bounded
@bors
Copy link

bors bot commented Jun 20, 2021

Build failed (retrying...):

Copy link
Collaborator

@bryangingechen bryangingechen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please merge master and fix this, thanks!
bors d+

src/topology/instances/real.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 20, 2021

✌️ benjamindavidson can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@bryangingechen
Copy link
Collaborator

bors r-

@bors
Copy link

bors bot commented Jun 20, 2021

Canceled.

@github-actions github-actions bot added the delegated The PR author may merge after reviewing final suggestions. label Jun 20, 2021
@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) labels Jun 20, 2021
@benjamindavidson
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jun 22, 2021
…pact range (and is hence bounded) (#7968)

A few more facts about periodic functions, namely:
- If a function `f` is `periodic` with positive period `p`,
  then for all `x` there exists `y` such that `y` is an element of `[0, p)` and `f x = f y`
- A continuous, periodic function has compact range
- A continuous, periodic function is bounded
@bors
Copy link

bors bot commented Jun 22, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/instances/real): a continuous periodic function has compact range (and is hence bounded) [Merged by Bors] - feat(topology/instances/real): a continuous periodic function has compact range (and is hence bounded) Jun 22, 2021
@bors bors bot closed this Jun 22, 2021
@bors bors bot deleted the bdd branch June 22, 2021 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting-author A reviewer has asked the author a question or requested changes delegated The PR author may merge after reviewing final suggestions.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants