Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory): computable 1st isomorphism theorem #7988

Closed
wants to merge 5 commits into from

Conversation

Vierkantor
Copy link
Collaborator

This PR defines a computable version of the first isomorphism theorem for groups and monoids that takes a right inverse of the map, quotient_ker_equiv_of_right_inverse.


Open in Gitpod

@Vierkantor Vierkantor added the awaiting-review The author would like community review of the PR label Jun 18, 2021
This PR defines a computable version of the first isomorphism theorem
for groups and monoids that takes a right inverse of the map,
`quotient_ker_equiv_of_right_inverse`.
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without lean open, I'm struggling to spot the difference between the two new equivs in this PR. Is there a difference?

@Vierkantor
Copy link
Collaborator Author

Without lean open, I'm struggling to spot the difference between the two new equivs in this PR. Is there a difference?

congruence.lean is for monoids in general, quotient_group.lean for groups specifically.

src/group_theory/congruence.lean Outdated Show resolved Hide resolved
src/group_theory/congruence.lean Outdated Show resolved Hide resolved
src/group_theory/quotient_group.lean Outdated Show resolved Hide resolved
src/group_theory/quotient_group.lean Outdated Show resolved Hide resolved
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

@bors
Copy link

bors bot commented Jun 18, 2021

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 18, 2021
@eric-wieser
Copy link
Member

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jun 18, 2021
bors bot pushed a commit that referenced this pull request Jun 18, 2021
This PR defines a computable version of the first isomorphism theorem for groups and monoids that takes a right inverse of the map, `quotient_ker_equiv_of_right_inverse`.



Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@bors
Copy link

bors bot commented Jun 19, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory): computable 1st isomorphism theorem [Merged by Bors] - feat(group_theory): computable 1st isomorphism theorem Jun 19, 2021
@bors bors bot closed this Jun 19, 2021
@bors bors bot deleted the quotient_ker_equiv_of_right_inverse branch June 19, 2021 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants