Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(topology/topological_fiber_bundle): reorganizing the code #7989

Closed
wants to merge 15 commits into from
Closed

[Merged by Bors] - chore(topology/topological_fiber_bundle): reorganizing the code #7989

wants to merge 15 commits into from

Conversation

Nicknamen
Copy link
Collaborator

@Nicknamen Nicknamen commented Jun 18, 2021 •
edited

Mainly redesigning the simp strategy.

Open in Gitpod

@Nicknamen Nicknamen requested a review from sgouezel June 18, 2021 15:51
@Nicknamen Nicknamen changed the title feat(topology/vector_bundle): topological_vector_bundle_code feat(topology/vector_bundle): topological_vector_bundle_core Jun 18, 2021
Nicknamen
Nicknamen commented Jun 18, 2021
View reviewed changes
src/topology/local_homeomorph.lean Outdated Show resolved Hide resolved
src/topology/topological_fiber_bundle.lean Outdated Show resolved Hide resolved
@Nicknamen Nicknamen added awaiting-review The author would like community review of the PR and removed awaiting-review The author would like community review of the PR labels Jun 18, 2021
@Nicknamen Nicknamen force-pushed the topological_vector_bundle_core branch from e5ecfd6 to 3b7ca99 Compare June 18, 2021 16:03
@Nicknamen Nicknamen force-pushed the topological_vector_bundle_core branch 2 times, most recently from c86e1bb to a9c40c1 Compare June 20, 2021 11:35
@Nicknamen Nicknamen force-pushed the topological_vector_bundle_core branch from a9c40c1 to 6eaf958 Compare June 20, 2021 11:39
@Nicknamen Nicknamen added the awaiting-review The author would like community review of the PR label Jun 20, 2021
sgouezel
sgouezel reviewed Jun 25, 2021
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR is called topological_vector_bundle_core, but I have reviewed 3/4 of it and it is only about refactoring topological fiber bundles. Could you remove the part about vector bundles from this PR, rename it, and add an appropriate PR description? I think this will make it much easier to review and merge quickly.

src/topology/continuous_on.lean Outdated Show resolved Hide resolved
src/topology/local_homeomorph.lean Show resolved Hide resolved
src/topology/order.lean Outdated Show resolved Hide resolved
src/topology/topological_fiber_bundle.lean Show resolved Hide resolved
src/topology/topological_fiber_bundle.lean Outdated Show resolved Hide resolved
@sgouezel sgouezel added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 25, 2021
@Nicknamen Nicknamen force-pushed the topological_vector_bundle_core branch from 0656d71 to 5e2f205 Compare June 26, 2021 18:13
@Nicknamen Nicknamen changed the title feat(topology/vector_bundle): topological_vector_bundle_core chore(topology/topological_fiber_bundle): reorganizing the code Jun 26, 2021
@Nicknamen Nicknamen added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 26, 2021
@Nicknamen
Copy link
Collaborator Author

Done!

@Nicknamen Nicknamen requested a review from sgouezel June 26, 2021 18:31
@Nicknamen Nicknamen mentioned this pull request Jun 26, 2021
Closed
1 task
sgouezel
sgouezel reviewed Jun 27, 2021
View reviewed changes
Copy link
Collaborator

@sgouezel sgouezel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the PR explanatory text?

src/topology/topological_fiber_bundle.lean Show resolved Hide resolved
@Nicknamen Nicknamen requested a review from sgouezel June 27, 2021 21:47
@Nicknamen Nicknamen requested a review from sgouezel June 28, 2021 13:13
@sgouezel
Copy link
Collaborator

bors r+
Thanks!

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 28, 2021
bors bot pushed a commit that referenced this pull request Jun 28, 2021
@Nicknamen
chore(topology/topological_fiber_bundle): reorganizing the code (#7989)
b160ac8 
Mainly redesigning the `simp` strategy.
@bors
Copy link

bors bot commented Jun 28, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(topology/topological_fiber_bundle): reorganizing the code [Merged by Bors] - chore(topology/topological_fiber_bundle): reorganizing the code Jun 28, 2021
@bors bors bot closed this Jun 28, 2021
@bors bors bot deleted the topological_vector_bundle_core branch June 28, 2021 15:38
b-mehta pushed a commit that referenced this pull request Jul 6, 2021
@Nicknamen @b-mehta
chore(topology/topological_fiber_bundle): reorganizing the code (#7989)
ff44129 
Mainly redesigning the `simp` strategy.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgouezel sgouezel Awaiting requested review from sgouezel

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Nicknamen @sgouezel