Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(analysis/mean_inequalities): split integral mean inequalities to a new file #7990

Closed
wants to merge 2 commits into from

Conversation

sgouezel
Copy link
Collaborator

@sgouezel sgouezel commented Jun 18, 2021

Currently, normed_space.dual imports a bunch of integration theory for no reason other than the file mean_inequalities contains both inequalities for finite sums and integrals. Splitting the file into two (and moving the integral versions to measure_theory) gives a more reasonable import graph.


no math changes at all

@sgouezel sgouezel added the awaiting-review The author would like community review of the PR label Jun 18, 2021
@hrmacbeth
Copy link
Member

hrmacbeth commented Jun 18, 2021

If I understand correctly, the analysis.special_functions.* files still import the beginning of measure theory (see import measure_theory.borel_space in analysis.special_functions.exp_log).

Are you planning to let this remain (so the point of the PR is to reduce the size of the measure theory import to mean_inequalities rather than eliminate it entirely)? We could get rid of the measure theory import completely if the measurabilty results moved to analysis.special_functions.integrals.

By the way, another possible improvement to the import graph would be to remove the inner_product_space theorems (i.e., Riesz representation theorem) from normed_space.dual and put them in analysis.normed_space.inner_product.

@sgouezel
Copy link
Collaborator Author

You're absolutely right that there is more to do to disentangle the imports. This PR is just one part of it, I'll probably go on improving the situation once this is merged.

@PatrickMassot
Copy link
Member

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 19, 2021
bors bot pushed a commit that referenced this pull request Jun 19, 2021
…o a new file (#7990)

Currently, `normed_space.dual` imports a bunch of integration theory for no reason other than the file `mean_inequalities` contains both inequalities for finite sums and integrals. Splitting the file into two (and moving the integral versions to `measure_theory`) gives a more reasonable import graph.
@bors
Copy link

bors bot commented Jun 19, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(analysis/mean_inequalities): split integral mean inequalities to a new file [Merged by Bors] - chore(analysis/mean_inequalities): split integral mean inequalities to a new file Jun 19, 2021
@bors bors bot closed this Jun 19, 2021
@bors bors bot deleted the split_mean_ineq branch June 19, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants