Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(analysis/liouville/liouville_constant.lean): create a file and introduce Liouville's constant #7996

Closed
wants to merge 25 commits into from
Closed

[Merged by Bors] - feat(analysis/liouville/liouville_constant.lean): create a file and introduce Liouville's constant #7996

wants to merge 25 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jun 19, 2021 •
edited by github-actions bot

Introduce a new file and the definition of Liouville's number. This is on the way to PR #4301.

Open in Gitpod

@adomani adomani added the awaiting-review The author would like community review of the PR label Jun 19, 2021
@adomani adomani mentioned this pull request Jun 19, 2021
Closed
@adomani adomani changed the title feat(analysis/transcendental/liouville_constant.lean): create a file and introduce Liouville's constant feat(analysis/liouville/liouville_constant.lean): create a file and introduce Liouville's constant Jun 19, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jun 19, 2021
@adomani adomani mentioned this pull request Jun 19, 2021
Closed
1 task
bors bot pushed a commit that referenced this pull request Jun 20, 2021
@adomani
chore(analysis/liouville/liouville + data/real/liouville): create fol…
547df12 
…der `analysis/liouville/`, move `data/real/liouville` into new folder (#7998)

This PR simply creates a new folder `analysis/liouville` and moves `data/real/liouville` into the new folder.  In PR #7996 I create a new Liouville-related file in the same folder.
adomani and others added 2 commits June 20, 2021 16:19
@adomani @bryangingechen
Apply suggestions from code review
246ed29 
Co-authored-by: Bryan Gin-ge Chen <bryangingechen@gmail.com>
@adomani
first_k to initial
595fb2b
@github-actions github-actions bot removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jun 20, 2021
@github-actions
Copy link

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@bryangingechen
Copy link
Collaborator

Thanks!
bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jun 20, 2021
bors bot pushed a commit that referenced this pull request Jun 21, 2021
@adomani
feat(analysis/liouville/liouville_constant.lean): create a file and i…
3925fc0 
…ntroduce Liouville's constant (#7996)

Introduce a new file and the definition of Liouville's number.  This is on the way to PR #4301.
@bors
Copy link

bors bot commented Jun 21, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(analysis/liouville/liouville_constant.lean): create a file and introduce Liouville's constant [Merged by Bors] - feat(analysis/liouville/liouville_constant.lean): create a file and introduce Liouville's constant Jun 21, 2021
@bors bors bot closed this Jun 21, 2021
@bors bors bot deleted the adomani_liouville_number_def branch June 21, 2021 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryangingechen bryangingechen bryangingechen left review comments

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@adomani @bryangingechen