Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(algebra/ordered_field): a few monotonicity results for powers #8022

Closed
wants to merge 11 commits into from
Closed

[Merged by Bors] - feat(algebra/ordered_field): a few monotonicity results for powers #8022

wants to merge 11 commits into from

Conversation

adomani
Copy link
Collaborator

@adomani adomani commented Jun 21, 2021 •
edited

This PR proves the monotonicity (strict and non-strict) of n → 1 / a ^ n, for a fixed a < 1 in a linearly ordered field. These are lemmas extracted from PR #8001: I moved them to a separate PR after the discussion there.

Open in Gitpod

@adomani adomani mentioned this pull request Jun 21, 2021
Closed
4 tasks
@ericrbg ericrbg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 21, 2021
ericrbg
ericrbg approved these changes Jun 21, 2021
View reviewed changes
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ericrbg ericrbg mentioned this pull request Jun 21, 2021
Closed
@jcommelin jcommelin self-assigned this Jun 22, 2021
jcommelin
jcommelin approved these changes Jun 22, 2021
View reviewed changes
Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One name seems to be a bit off.

bors d+

src/algebra/ordered_field.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jun 22, 2021

✌️ adomani can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 22, 2021
@adomani @jcommelin
Update src/algebra/ordered_field.lean
6e51f7b 
Co-authored-by: Johan Commelin <johan@commelin.net>
@adomani
Copy link
Collaborator Author

adomani commented Jun 22, 2021

Thanks, Johan! I updated the name with your suggestion and will wait for CI to finish before merging!

eric-wieser
eric-wieser reviewed Jun 22, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the new lemmas, they look good other than the names

adomani and others added 3 commits June 22, 2021 17:03
@adomani @eric-wieser
Apply suggestions from code review
4e68f00 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@adomani
fix
e63efff
@adomani
golf
d7dd353
@adomani
Copy link
Collaborator Author

adomani commented Jun 22, 2021

bors e+

@ericrbg
Copy link
Collaborator

ericrbg commented Jun 22, 2021

damiano, you used the wrong letter :b

@adomani
Copy link
Collaborator Author

adomani commented Jun 23, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jun 23, 2021
@adomani
feat(algebra/ordered_field): a few monotonicity results for powers (#…
1670caa 
…8022)

This PR proves the monotonicity (strict and non-strict) of `n → 1 / a ^ n`, for a fixed `a < 1` in a linearly ordered field.  These are lemmas extracted from PR #8001: I moved them to a separate PR after the discussion there.
@adomani
Copy link
Collaborator Author

adomani commented Jun 23, 2021

Eric, thanks! I used my phone and r got "corrected" to e, since I had the Italian keyboard activated!

@bors
Copy link

bors bot commented Jun 23, 2021

Build failed:

@adomani
Copy link
Collaborator Author

adomani commented Jun 23, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jun 23, 2021
@adomani
feat(algebra/ordered_field): a few monotonicity results for powers (#…
0bc09d9 
…8022)

This PR proves the monotonicity (strict and non-strict) of `n → 1 / a ^ n`, for a fixed `a < 1` in a linearly ordered field.  These are lemmas extracted from PR #8001: I moved them to a separate PR after the discussion there.
@bors
Copy link

bors bot commented Jun 23, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(algebra/ordered_field): a few monotonicity results for powers [Merged by Bors] - feat(algebra/ordered_field): a few monotonicity results for powers Jun 23, 2021
@bors bors bot closed this Jun 23, 2021
@bors bors bot deleted the adomani_mono_powers_from_liouville branch June 23, 2021 02:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@b-mehta b-mehta b-mehta left review comments

@jcommelin jcommelin jcommelin approved these changes

@ericrbg ericrbg ericrbg approved these changes

Assignees

@jcommelin jcommelin

Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@adomani @ericrbg @eric-wieser @jcommelin @b-mehta