Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/polynomial): aeval_alg_equiv, like aeval_alg_hom #8038

Closed
wants to merge 2 commits into from
Closed

[Merged by Bors] - feat(data/polynomial): aeval_alg_equiv, like aeval_alg_hom #8038

wants to merge 2 commits into from

Conversation

Vierkantor
Copy link
Collaborator

@Vierkantor Vierkantor commented Jun 22, 2021 •
edited

This PR copies polynomial.aeval_alg_hom and aeval_alg_hom_apply to aeval_alg_equiv(_apply).

Open in Gitpod

@Vierkantor Vierkantor added awaiting-review The author would like community review of the PR blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jun 22, 2021
@Vierkantor Vierkantor mentioned this pull request Jun 22, 2021
Closed
1 task
@Vierkantor Vierkantor closed this Jun 23, 2021
@Vierkantor Vierkantor reopened this Jun 24, 2021
@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR awaiting-author A reviewer has asked the author a question or requested changes labels Jun 24, 2021
@Vierkantor Vierkantor changed the title feat(data/polynomial): alg_hom and alg_equivs preserve aeval feat(data/polynomial): aeval_alg_equiv, like aeval_alg_hom Jun 24, 2021
@Vierkantor Vierkantor added the awaiting-review The author would like community review of the PR label Jun 24, 2021
@Vierkantor
feat(data/polynomial): alg_hom and alg_equivs preserve aeval
18094f9 
This PR shows `e (aeval x f) = aeval (e x) f` if `e` is an `alg_hom` or `alg_equiv`
@Vierkantor
Instead of alg_equiv.map_aeval, define aeval_alg_equiv to better …
c8240bf 
…fit the existing `aeval_alg_hom`
@Vierkantor Vierkantor removed the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jun 24, 2021
eric-wieser
eric-wieser approved these changes Jun 24, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors d+

Thanks!

@bors
Copy link

bors bot commented Jun 24, 2021

✌️ Vierkantor can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jun 24, 2021
@Vierkantor
Copy link
Collaborator Author

bors r+

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jun 24, 2021
bors bot pushed a commit that referenced this pull request Jun 24, 2021
@Vierkantor
feat(data/polynomial): aeval_alg_equiv, like aeval_alg_hom (#8038)
db84f2b 
This PR copies `polynomial.aeval_alg_hom` and `aeval_alg_hom_apply` to `aeval_alg_equiv(_apply)`.
@bors
Copy link

bors bot commented Jun 24, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/polynomial): aeval_alg_equiv, like aeval_alg_hom [Merged by Bors] - feat(data/polynomial): aeval_alg_equiv, like aeval_alg_hom Jun 24, 2021
@bors bors bot closed this Jun 24, 2021
@bors bors bot deleted the alg_hom-map_aeval branch June 24, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Vierkantor @eric-wieser