Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/nat/prime): fix + add missing lemmas #8066

Closed
wants to merge 3 commits into from

Conversation

ericrbg
Copy link
Collaborator

@ericrbg ericrbg commented Jun 24, 2021

I fixed up some indents as well, as they were bothering me quite a bit. The only "new" content is 597 - 617.


Open in Gitpod

I fixed-up the indent to how it should be
@ericrbg ericrbg added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jun 24, 2021
Copy link
Collaborator

@Ruben-VandeVelde Ruben-VandeVelde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense - some stylistic comments below

src/data/nat/prime.lean Outdated Show resolved Hide resolved
src/data/nat/prime.lean Outdated Show resolved Hide resolved
src/data/nat/prime.lean Outdated Show resolved Hide resolved
src/data/nat/prime.lean Show resolved Hide resolved
src/data/nat/prime.lean Outdated Show resolved Hide resolved
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 30, 2021
@ericrbg ericrbg added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 4, 2021
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

src/data/nat/prime.lean Outdated Show resolved Hide resolved
src/data/nat/prime.lean Outdated Show resolved Hide resolved
src/data/nat/prime.lean Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 12, 2021

✌️ ericrbg can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 12, 2021
src/data/nat/prime.lean Outdated Show resolved Hide resolved
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@ericrbg
Copy link
Collaborator Author

ericrbg commented Jul 13, 2021

bors r+

bors bot pushed a commit that referenced this pull request Jul 13, 2021
I fixed up some indents as well, as they were bothering me quite a bit. The only "new" content is 597 - 617.
@bors
Copy link

bors bot commented Jul 13, 2021

Build failed (retrying...):

bors bot pushed a commit that referenced this pull request Jul 13, 2021
I fixed up some indents as well, as they were bothering me quite a bit. The only "new" content is 597 - 617.
@bors
Copy link

bors bot commented Jul 13, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/nat/prime): fix + add missing lemmas [Merged by Bors] - chore(data/nat/prime): fix + add missing lemmas Jul 13, 2021
@bors bors bot closed this Jul 13, 2021
@bors bors bot deleted the factors_subset branch July 13, 2021 16:48
b-mehta pushed a commit that referenced this pull request Jul 20, 2021
I fixed up some indents as well, as they were bothering me quite a bit. The only "new" content is 597 - 617.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants