Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - docs(data/fintype/basic): add module docstring #8081

Closed
wants to merge 5 commits into from
Closed

[Merged by Bors] - docs(data/fintype/basic): add module docstring #8081

wants to merge 5 commits into from

Conversation

YaelDillies
Copy link
Collaborator

Open in Gitpod

@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR lintfix This PR only fixes linting errors labels Jun 25, 2021
eric-wieser
eric-wieser reviewed Jun 27, 2021
View reviewed changes
src/data/fintype/basic.lean Outdated
Comment on lines 51 to 52
* Types which have a surjection from/an injection to a fintype. See `fintype.of_injective` and
`fintype.of_surjective`.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't an instance - this is just machinery to construct instances with. I think this belongs in a separate list.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about now? I'm not very inspired.

@bryangingechen bryangingechen added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jun 30, 2021
@YaelDillies YaelDillies added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jun 30, 2021
Vierkantor
Vierkantor approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 🎉

bors d+

src/data/fintype/basic.lean Outdated Show resolved Hide resolved
src/data/fintype/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 12, 2021

✌️ YaelDillies can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 12, 2021
@YaelDillies
Copy link
Collaborator Author

bors merge

bors bot pushed a commit that referenced this pull request Jul 16, 2021
@YaelDillies
docs(data/fintype/basic): add module docstring (#8081)
728eefe
@bors
Copy link

bors bot commented Jul 16, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title docs(data/fintype/basic): add module docstring [Merged by Bors] - docs(data/fintype/basic): add module docstring Jul 16, 2021
@bors bors bot closed this Jul 16, 2021
@bors bors bot deleted the yael/fintype branch July 16, 2021 06:48
b-mehta pushed a commit that referenced this pull request Jul 20, 2021
@YaelDillies @b-mehta
docs(data/fintype/basic): add module docstring (#8081)
f45454b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vierkantor Vierkantor Vierkantor approved these changes

@eric-wieser eric-wieser Awaiting requested review from eric-wieser

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. lintfix This PR only fixes linting errors
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@YaelDillies @eric-wieser @Vierkantor @bryangingechen