Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(category_theory): homogenise usage of notation for terminal objects #8106

Closed
wants to merge 1 commit into from

Conversation

TwoFX
Copy link
Member

@TwoFX TwoFX commented Jun 28, 2021

I went with the option that is used more frequently, but I'm also happy to switch to the space-less option if people prefer it.


Open in Gitpod

@b-mehta
Copy link
Collaborator

b-mehta commented Jul 6, 2021

I'm happy with this! Perhaps others could chime in on which they prefer, but I think homogenising is important whichever one we go with. @jcommelin @adamtopaz

@adamtopaz
Copy link
Collaborator

I'm happy with this! Perhaps others could chime in on which they prefer, but I think homogenising is important whichever one we go with. @jcommelin @adamtopaz

LGTM!

Copy link
Member

@jcommelin jcommelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 7, 2021
bors bot pushed a commit that referenced this pull request Jul 7, 2021
…ects (#8106)

I went with the option that is used more frequently, but I'm also happy to switch to the space-less option if people prefer it.
@bors
Copy link

bors bot commented Jul 7, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(category_theory): homogenise usage of notation for terminal objects [Merged by Bors] - chore(category_theory): homogenise usage of notation for terminal objects Jul 7, 2021
@bors bors bot closed this Jul 7, 2021
@bors bors bot deleted the initial_notation branch July 7, 2021 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants