Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(group_theory/subgroup): saturated subgroups #8137

Closed
wants to merge 6 commits into from
Closed

[Merged by Bors] - feat(group_theory/subgroup): saturated subgroups #8137

wants to merge 6 commits into from

Conversation

jcommelin
Copy link
Member

From LTE

Open in Gitpod

@jcommelin jcommelin added the awaiting-review The author would like community review of the PR label Jun 30, 2021
@jcommelin @eric-wieser
Apply suggestions from code review
4f81552 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
@eric-wieser
Copy link
Member

I think @fpvandoorn is just around the corner from making to_additive work properly on smul / npow - perhaps it makes sense to wait for that PR first?

Vierkantor
Vierkantor approved these changes Jul 12, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you try to merge master and applying to_additive to this file?

LGTM otherwise.

@Vierkantor Vierkantor added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 12, 2021
@jcommelin
Copy link
Member Author

Done. It works great! Thanks @fpvandoorn 🐙

@fpvandoorn
Copy link
Member

Good to hear!

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-author A reviewer has asked the author a question or requested changes labels Aug 9, 2021
bors bot pushed a commit that referenced this pull request Aug 9, 2021
@jcommelin
feat(group_theory/subgroup): saturated subgroups (#8137)
f3b70e4 
From LTE
@bors
Copy link

bors bot commented Aug 9, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/subgroup): saturated subgroups [Merged by Bors] - feat(group_theory/subgroup): saturated subgroups Aug 9, 2021
@bors bors bot closed this Aug 9, 2021
@bors bors bot deleted the saturated-subgroup-def branch August 9, 2021 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jcommelin @eric-wieser @fpvandoorn @Vierkantor