Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - feat(group_theory/perm/cycles): more lemmas #8175

Closed
wants to merge 17 commits into from

Conversation

pechersky
Copy link
Collaborator

@pechersky pechersky commented Jul 1, 2021

@pechersky pechersky added the awaiting-review The author would like community review of the PR label Jul 1, 2021
@github-actions github-actions bot added the blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. label Jul 2, 2021
@github-actions github-actions bot added the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 4, 2021
@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 7, 2021
@github-actions github-actions bot added merge-conflict Please `git merge origin/master` then a bot will remove this label. and removed blocked-by-other-PR This PR depends on another PR which is still in the queue. A bot manages this label via PR comment. labels Jul 8, 2021
@github-actions
Copy link

github-actions bot commented Jul 8, 2021

🎉 Great news! Looks like all the dependencies have been resolved:

💡 To add or remove a dependency please update this issue/PR description.

Brought to you by Dependent Issues (:robot: ). Happy coding!

@github-actions github-actions bot removed the merge-conflict Please `git merge origin/master` then a bot will remove this label. label Jul 8, 2021
rw h
end

attribute [to_additive nsmul_inj_mod] pow_inj_mod
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work directly on the lemmas now that to_additive knows about smul and pow? Or is that PR still unmerged?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After merging master,

type mismatch at application
  @nsmul_injective_of_lt_add_order_of G x
    (n % @add_order_of G (@sub_neg_monoid.to_add_monoid G (@add_group.to_sub_neg_monoid G _inst_1)) x)
term
  n % @add_order_of G (@sub_neg_monoid.to_add_monoid G (@add_group.to_sub_neg_monoid G _inst_1)) x
has type
  ℕ
but is expected to have type
  add_left_cancel_monoid G

So it seems a separate lemma proof is necessary.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fpvandoorn, any ideas?

@jcommelin
Copy link
Member

This is quite a large PR, but what I've seen looks good to me.

@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 27, 2021
bors bot pushed a commit that referenced this pull request Jul 27, 2021
@bors
Copy link

bors bot commented Jul 27, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(group_theory/perm/cycles): more lemmas [Merged by Bors] - feat(group_theory/perm/cycles): more lemmas Jul 27, 2021
@bors bors bot closed this Jul 27, 2021
@bors bors bot deleted the pechersky/more-perm-cycle branch July 27, 2021 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants