-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(group_theory/perm/cycles): more lemmas #8175
Conversation
pechersky
commented
Jul 1, 2021
•
edited by bryangingechen
edited by bryangingechen
- depends on: [Merged by Bors] - feat(data/finset/noncomm_prod): noncomm_prod_union_of_disjoint #8169
…union' into pechersky/more-perm-cycle
…sjoint" This reverts commit a2a427a.
…-prod-disjoint-union
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
rw h | ||
end | ||
|
||
attribute [to_additive nsmul_inj_mod] pow_inj_mod |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this work directly on the lemmas now that to_additive
knows about smul and pow? Or is that PR still unmerged?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After merging master,
type mismatch at application
@nsmul_injective_of_lt_add_order_of G x
(n % @add_order_of G (@sub_neg_monoid.to_add_monoid G (@add_group.to_sub_neg_monoid G _inst_1)) x)
term
n % @add_order_of G (@sub_neg_monoid.to_add_monoid G (@add_group.to_sub_neg_monoid G _inst_1)) x
has type
ℕ
but is expected to have type
add_left_cancel_monoid G
So it seems a separate lemma proof is necessary.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fpvandoorn, any ideas?
This is quite a large PR, but what I've seen looks good to me. |
Thanks 🎉 bors merge |
Pull request successfully merged into master. Build succeeded: |