Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(measure_theory/measure_space): add missing finite_measure instances #8214

Closed
wants to merge 3 commits into from

Conversation

JasonKYi
Copy link
Member

@JasonKYi JasonKYi commented Jul 6, 2021


Open in Gitpod

@JasonKYi JasonKYi added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 6, 2021
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable, but this is not my area of expertise

Copy link
Member

@fpvandoorn fpvandoorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -435,6 +435,9 @@ instance : module ℝ≥0∞ (measure α) :=
injective.module ℝ≥0∞ ⟨to_outer_measure, zero_to_outer_measure, add_to_outer_measure⟩
to_outer_measure_injective smul_to_outer_measure

@[simp, norm_cast] theorem coe_nnreal_smul (c : ℝ≥0) (μ : measure α) : ⇑(c • μ) = c • μ :=
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a specific type ascription here? I don't know whether this is (c • μ : outer_measure α) or (c • μ : α -> ennreal)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, it is the coe_to_fun arrow. Still I'd appreciate the explicit typing.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current spelling matches the statement of coe_smul a few lines above, and in various places throughout mathlib.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, never mind then

bors merge

bors bot pushed a commit that referenced this pull request Jul 7, 2021
@bors
Copy link

bors bot commented Jul 7, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(measure_theory/measure_space): add missing finite_measure instances [Merged by Bors] - chore(measure_theory/measure_space): add missing finite_measure instances Jul 7, 2021
@bors bors bot closed this Jul 7, 2021
@bors bors bot deleted the JasonKYi/finite_measure_instance branch July 7, 2021 13:34
@YaelDillies YaelDillies removed the awaiting-review The author would like community review of the PR label Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants