Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(data/nat/basic): lt_one_iff #8224

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - feat(data/nat/basic): lt_one_iff #8224

wants to merge 3 commits into from

Conversation

pechersky
Copy link
Collaborator

Open in Gitpod

@pechersky pechersky added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 8, 2021
@pechersky pechersky mentioned this pull request Jul 8, 2021
Closed
4 tasks
eric-wieser
eric-wieser reviewed Jul 8, 2021
View reviewed changes
src/data/nat/basic.lean Outdated Show resolved Hide resolved
@eric-wieser eric-wieser added awaiting-author A reviewer has asked the author a question or requested changes and removed awaiting-review The author would like community review of the PR labels Jul 8, 2021
@eric-wieser eric-wieser added awaiting-review The author would like community review of the PR and removed awaiting-author A reviewer has asked the author a question or requested changes labels Jul 8, 2021
Vierkantor
Vierkantor reviewed Jul 8, 2021
View reviewed changes
src/data/nat/basic.lean Outdated Show resolved Hide resolved
@bors
Copy link

bors bot commented Jul 8, 2021

✌️ pechersky can now approve this pull request. To approve and merge a pull request, simply reply with bors r+. More detailed instructions are available here.

Vierkantor
Vierkantor approved these changes Jul 8, 2021
View reviewed changes
Copy link
Collaborator

@Vierkantor Vierkantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

bors d+

@github-actions github-actions bot added delegated The PR author may merge after reviewing final suggestions. and removed awaiting-review The author would like community review of the PR labels Jul 8, 2021
@eric-wieser
Copy link
Member

bors merge

@github-actions github-actions bot added the ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) label Jul 8, 2021
bors bot pushed a commit that referenced this pull request Jul 8, 2021
@pechersky @eric-wieser @Vierkantor
feat(data/nat/basic): lt_one_iff (#8224)
a4b0b48 
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
Co-authored-by: Anne Baanen <Vierkantor@users.noreply.github.com>
@bors
Copy link

bors bot commented Jul 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(data/nat/basic): lt_one_iff [Merged by Bors] - feat(data/nat/basic): lt_one_iff Jul 8, 2021
@bors bors bot closed this Jul 8, 2021
@bors bors bot deleted the pechersky/nat-lt-one-iff branch July 8, 2021 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser left review comments

@Vierkantor Vierkantor Vierkantor approved these changes

Assignees
No one assigned
Labels
delegated The PR author may merge after reviewing final suggestions. easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pechersky @eric-wieser @Vierkantor