Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - chore(group_theory/perm/support): support_pow_le over nat #8225

Closed
wants to merge 3 commits into from
Closed

[Merged by Bors] - chore(group_theory/perm/support): support_pow_le over nat #8225

wants to merge 3 commits into from

Conversation

pechersky
Copy link
Collaborator

Previously, both support_pow_le and support_gpow_le had the
power as an int. Now we properly differentiate the two and avoid
slow defeq checks.

Open in Gitpod

@pechersky
chore(group_theory/perm/support): support_pow_le over nat
e99ad3b 
Previously, both `support_pow_le` and `support_gpow_le` had the
power as an `int`. Now we properly differentiate the two and avoid
slow defeq checks.
@pechersky
fix renames
111ad4f
@pechersky pechersky added awaiting-review The author would like community review of the PR easy < 20s of review time. See the lifecycle page for guidelines. labels Jul 8, 2021
@pechersky pechersky removed the easy < 20s of review time. See the lifecycle page for guidelines. label Jul 8, 2021
@pechersky pechersky mentioned this pull request Jul 8, 2021
Closed
4 tasks
eric-wieser
eric-wieser approved these changes Jul 8, 2021
View reviewed changes
Copy link
Member

@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bors r+

Nice catch, it's a shame we don't have a linter to catch identical lemma statements like this

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 8, 2021
bors bot pushed a commit that referenced this pull request Jul 8, 2021
@pechersky
chore(group_theory/perm/support): support_pow_le over nat (#8225)
03e2cbd 
Previously, both `support_pow_le` and `support_gpow_le` had the
power as an `int`. Now we properly differentiate the two and avoid
slow defeq checks.
@bors
Copy link

bors bot commented Jul 8, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(group_theory/perm/support): support_pow_le over nat [Merged by Bors] - chore(group_theory/perm/support): support_pow_le over nat Jul 8, 2021
@bors bors bot closed this Jul 8, 2021
@bors bors bot deleted the pechersky/support-pow-le-chore branch July 8, 2021 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pechersky @eric-wieser