[Merged by Bors] - refactor(analysis/analytic/basic): refactor change_origin
#8282
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
blocked-by-other-PR
Co-authored-by: Ruben Van de Velde <65514131+Ruben-VandeVelde@users.noreply.github.com>
github-actions
bot
removed
the
blocked-by-other-PR
|
🎉 Great news! Looks like all the dependencies have been resolved: 💡 To add or remove a dependency please update this issue/PR description. Brought to you by Dependent Issues (:robot: ). Happy coding! |
…/mathlib into change-origin
sgouezel
reviewed
Jul 15, 2021
src/analysis/analytic/basic.lean
Outdated
|
|
||
| variables (p : formal_multilinear_series 𝕜 E F) {x y : E} {r R : ℝ≥0} | ||
|
|
||
| /-- A term of `formal_multilinear_series.change_origin_series`. -/ |
There was a problem hiding this comment.
Can you expand the docstring? I.e., recall whay change_origin_series is gonna be, and what is its role?
src/analysis/analytic/basic.lean
Outdated
| apply continuous_multilinear_map.le_op_nnnorm | ||
| end | ||
|
|
||
| /-- The power series for `f.change_origin k`. -/ |
There was a problem hiding this comment.
Can you explain what f.change_origin k is in the docstring?
src/analysis/analytic/basic.lean
Outdated
| series of terms `B`, and we show that they correspond to each other by reordering to conclude the | ||
| proof. -/ | ||
| theorem change_origin_eval (h : (∥x∥₊ + ∥y∥₊ : ℝ≥0∞) < p.radius) : | ||
| (p.change_origin x).sum y = (p.sum (x + y)) := |
There was a problem hiding this comment.
Suggested change
| (p.change_origin x).sum y = (p.sum (x + y)) := | |
| (p.change_origin x).sum y = (p.sum (x + y)) := |
|
✌️ urkud can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 17, 2021
Now each term of `change_origin` is defined as a sum of a formal power series, so it is clear that each term is an analytic function. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
change_originchange_origin
b-mehta
pushed a commit
that referenced
this pull request
Jul 20, 2021
Now each term of `change_origin` is defined as a sum of a formal power series, so it is clear that each term is an analytic function. Co-authored-by: sgouezel <sebastien.gouezel@univ-rennes1.fr>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now each term of
change_originis defined as a sum of a formal power series, so it is clear that each term is an analytic function.mul_le_mul'forcanonically_ordered_comm_semiring#8284