[Merged by Bors] - feat(group_theory/order_of_element): pow_eq_mod_card #8354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ChrisHughes24
commented
Jul 17, 2021
ChrisHughes24
commented
ChrisHughes24
added
the
awaiting-review
eric-wieser
reviewed
Jul 17, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
eric-wieser
changed the title
eric-wieser
approved these changes
Jul 19, 2021
Comment on lines
776
to
777
| by rw [pow_eq_mod_order_of, @pow_eq_mod_order_of _ _ _ (_ % fintype.card G), | ||
| nat.mod_mod_of_dvd _ order_of_dvd_card_univ] |
There was a problem hiding this comment.
You can avoid the @ here by writing in reverse:
Suggested change
| by rw [pow_eq_mod_order_of, @pow_eq_mod_order_of _ _ _ (_ % fintype.card G), | |
| nat.mod_mod_of_dvd _ order_of_dvd_card_univ] | |
| by rw [pow_eq_mod_order_of, ←nat.mod_mod_of_dvd n order_of_dvd_card_univ, ←pow_eq_mod_order_of] |
Comment on lines
781
to
782
| by rw [gpow_eq_mod_order_of, @gpow_eq_mod_order_of _ _ _ (_ % fintype.card G), | ||
| int.mod_mod_of_dvd _ (int.coe_nat_dvd.2 order_of_dvd_card_univ)] |
There was a problem hiding this comment.
Although it's less effective here.
Suggested change
| by rw [gpow_eq_mod_order_of, @gpow_eq_mod_order_of _ _ _ (_ % fintype.card G), | |
| int.mod_mod_of_dvd _ (int.coe_nat_dvd.2 order_of_dvd_card_univ)] | |
| by rw [gpow_eq_mod_order_of, ←int.mod_mod_of_dvd n (int.coe_nat_dvd.2 order_of_dvd_card_univ), | |
| ←gpow_eq_mod_order_of] |
|
✌️ ChrisHughes24 can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
|
bors merge |
github-actions
bot
added
the
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Jul 20, 2021
Co-authored-by: Chris Hughes <33847686+ChrisHughes24@users.noreply.github.com>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.