[Merged by Bors] - feat(algebra/group/defs): ext lemmas for (semi)groups and monoids #8391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
bryangingechen
added
the
awaiting-review
eric-wieser
reviewed
Jul 22, 2021
eric-wieser
reviewed
Jul 22, 2021
Co-authored-by: Eric Wieser <wieser.eric@gmail.com>
bryangingechen
added
awaiting-author
bryangingechen
added
awaiting-review
bryangingechen
commented
Aug 23, 2021
There was a problem hiding this comment.
@eric-wieser I was able to use your injective strategy throughout, except around div_inv_monoid and group; if you wouldn't mind taking a look, I'd be grateful. Following your suggestion I changed all the ext lemmas stated explicitly here to use {{ brackets, but note that some of the new ext lemmas are generated by the ext attribute.
|
bors d+ |
|
✌️ bryangingechen can now approve this pull request. To approve and merge a pull request, simply reply with |
github-actions
bot
added
delegated
bryangingechen
added
the
awaiting-author
|
Thanks to Eric and Chris for the review and suggestions! |
github-actions
bot
added
ready-to-merge
bors bot
pushed a commit
that referenced
this pull request
Sep 1, 2021
) [Zulip discussion](https://leanprover.zulipchat.com/#narrow/stream/144837-PR-reviews/topic/.236476.20boolean_algebra.2Eto_boolean_ring/near/242118386) Co-authored-by: Kevin Buzzard <k.buzzard@imperial.ac.uk>
|
Pull request successfully merged into master. Build succeeded: |
bors
bot
changed the title
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Zulip discussion
Co-authored-by: Kevin Buzzard k.buzzard@imperial.ac.uk
As you can see, this PR is very repetitive; are there some improvements to the
extattribute or some other automation we can use here?