Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Merged by Bors] - chore(data/pnat/basic): rename bot_eq_zero to bot_eq_one, generalize from Prop to Sort* #8412

Closed
wants to merge 4 commits into from

Conversation

YaelDillies
Copy link
Collaborator


bot_eq_zero : (⊥ : ℕ+) = 1 sounded odd!
I also did some whitespace changes and generalized strong_induction_on from ℕ+ → Prop to ℕ+ → Sort*.
Open in Gitpod

@YaelDillies YaelDillies added easy < 20s of review time. See the lifecycle page for guidelines. awaiting-review The author would like community review of the PR labels Jul 24, 2021
@YaelDillies YaelDillies changed the title chore(data/pnat/basic): rename bot_eq_zero to bot_eq_one chore(data/pnat/basic): rename bot_eq_zero to bot_eq_one, generalize from Prop to Sort* Jul 24, 2021
Copy link
Collaborator

@ericrbg ericrbg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

otherwise LGTM

src/data/pnat/basic.lean Outdated Show resolved Hide resolved
src/data/pnat/basic.lean Show resolved Hide resolved
@jcommelin
Copy link
Member

Thanks 🎉

bors merge

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 26, 2021
bors bot pushed a commit that referenced this pull request Jul 26, 2021
@bors
Copy link

bors bot commented Jul 26, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title chore(data/pnat/basic): rename bot_eq_zero to bot_eq_one, generalize from Prop to Sort* [Merged by Bors] - chore(data/pnat/basic): rename bot_eq_zero to bot_eq_one, generalize from Prop to Sort* Jul 26, 2021
@bors bors bot closed this Jul 26, 2021
@bors bors bot deleted the bot_eq_one branch July 26, 2021 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy < 20s of review time. See the lifecycle page for guidelines. ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants