-
Notifications
You must be signed in to change notification settings - Fork 299
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Merged by Bors] - feat(analysis/complex/basic): add several trivial lemmas for differentiable functions. #8418
Conversation
src/analysis/complex/basic.lean
Outdated
|
||
variables {f : ℂ → ℂ} {z : ℂ} | ||
|
||
lemma fderiv_eq_fderiv_of_holomorph (h : differentiable_at ℂ f z) : |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know the conventions... have we established to write of_holomorph
for complex differentiable functions?
src/analysis/complex/basic.lean
Outdated
by { rw (h.restrict_scalars ℝ).has_fderiv_at.unique (h.has_fderiv_at.restrict_scalars ℝ), | ||
simp only [coe_restrict_scalars'], } | ||
|
||
lemma has_fderiv_at_of_eq {f' : ℂ →L[ℝ] ℂ} {g' : ℂ →L[ℂ] ℂ} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be generalized away from the reals and complexes? I can imagine this might be useful for other extensions of complete normed fields (or whatever assumptions are needed to get fderiv
working).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think generalizing these lemmas (fderiv_eq_fderiv_of_holomorph
and has_fderiv_at_of_eq
) would be really nice.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems that I can also generalize the lemma holomorphic_iff_is_complex_linear
(the old is_complex_linear_iff_holomorph
) to differentiable_iff_is_linear_map
, but I am not sure if that's something useful for other fields.
There's a general shift away from unbundled statements (eg, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! These lemmas are hard to name, but I think an important point is that all of them should have restrict_scalars
in the name somewhere.
Maybe has_fderiv_within_at_of_restrict_scalars
instead of has_fderiv_within_at_of_eq
, and differentiable_within_at_iff_restrict_scalars
instead of differentiable_within_at_iff_exists_linear_map
? (Unfortunately these names are still a bit misleading.) Or let me know if you have other ideas.
Co-authored-by: hrmacbeth <25316162+hrmacbeth@users.noreply.github.com>
Co-authored-by: hrmacbeth <25316162+hrmacbeth@users.noreply.github.com>
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
bors d+
✌️ justadzr can now approve this pull request. To approve and merge a pull request, simply reply with |
Co-authored-by: hrmacbeth <25316162+hrmacbeth@users.noreply.github.com>
bors r+ |
…tiable functions. (#8418) This file relates the differentiability of a function to the linearity of its `fderiv`. Co-authored-by: justadzr <66561890+justadzr@users.noreply.github.com>
Pull request successfully merged into master. Build succeeded: |
This file relates the differentiability of a function to the linearity of its
fderiv
.Hello, some of the lemmas are quite trivial but are mentioned/used previously in other PRs or branches. I am not sure if analysis/complex/basic is the right place to put these lemmas, but it seems to me that similar lemmas were put in this particular file in the branch "complex-diff".