Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat(topology/instances/ennreal): diameter of s : set real #8433

Closed
wants to merge 4 commits into from
Closed

[Merged by Bors] - feat(topology/instances/ennreal): diameter of s : set real #8433

wants to merge 4 commits into from

Conversation

urkud
Copy link
Member

@urkud urkud commented Jul 26, 2021

Open in Gitpod

@urkud
chore(data/real/basic): a few fixes about Sup/Inf on ℝ
8e37c69 
* rename `real.add_pos_lt_Sup` to `real.add_neg_lt_Sup`;
* add `@[simp]` to `real.Sup_empty` and `real.Inf_empty`;
* replace some calls to `simp` by `exact`;
* add `real.Inf_le_Sup`.
@urkud
Snapshot
ca60715
@urkud
Merge branch 'real-inf-sup' into real-diam
b9c94c5
@urkud
Move, golf
b7e826c
@urkud urkud added the awaiting-review The author would like community review of the PR label Jul 26, 2021
@urkud urkud mentioned this pull request Jul 26, 2021
Closed
1 task
@sgouezel
Copy link
Collaborator

bors r+

@github-actions github-actions bot added ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.) and removed awaiting-review The author would like community review of the PR labels Jul 27, 2021
@sgouezel sgouezel mentioned this pull request Jul 27, 2021
Closed
bors bot pushed a commit that referenced this pull request Jul 27, 2021
@urkud
feat(topology/instances/ennreal): diameter of s : set real (#8433)
eae3ead
@bors
Copy link

bors bot commented Jul 27, 2021

Pull request successfully merged into master.

Build succeeded:

@bors bors bot changed the title feat(topology/instances/ennreal): diameter of s : set real [Merged by Bors] - feat(topology/instances/ennreal): diameter of s : set real Jul 27, 2021
@bors bors bot closed this Jul 27, 2021
@bors bors bot deleted the real-diam branch July 27, 2021 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ready-to-merge All that is left is for bors to build and merge this PR. (Remember you need to say `bors r+`.)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@urkud @sgouezel